You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/27 15:17:13 UTC

[GitHub] [beam] KhaninArtur commented on a change in pull request #16365: [BEAM-13559][Playground] Remove tag in examples CD

KhaninArtur commented on a change in pull request #16365:
URL: https://github.com/apache/beam/pull/16365#discussion_r775542448



##########
File path: playground/infrastructure/test_helper.py
##########
@@ -135,15 +135,15 @@ def test__check_file_with_correct_tag(
   assert len(examples) == 1
   assert examples[0] == example
   mock_get_tag.assert_called_once_with("/root/filename.java")
-  mock_validate.assert_called_once_with(tag, [])
+  mock_validate.assert_called_once_with(tag.tag_as_dict, [])

Review comment:
       Can we add a test case(-s) to check that the collected `tag_string` is correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org