You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/05 19:42:55 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
MaxGekk opened a new pull request #28999:
URL: https://github.com/apache/spark/pull/28999
### What changes were proposed in this pull request?
Replace the combination of expressions `SecondsToTimestamp` and `UnixTimestamp` by `GetTimestamp` in `ParseToDate`.
### Why are the changes needed?
Eliminate unnecessary parsing overhead in: **string -> timestamp -> long (seconds) -> timestamp -> date**. After the changes, the chain will be: **string -> timestamp -> date**.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By existing test suites such as `DateFunctionsSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653976770
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008047
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654861466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654669317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008050
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125014/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653944034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654644368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654079926
**[Test build #125046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125046/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28999:
URL: https://github.com/apache/spark/pull/28999#discussion_r450550096
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1450,8 +1450,7 @@ case class ParseToDate(left: Expression, format: Option[Expression], child: Expr
extends RuntimeReplaceable {
def this(left: Expression, format: Expression) {
- this(left, Option(format),
- Cast(SecondsToTimestamp(UnixTimestamp(left, format)), DateType))
Review comment:
Yeah, I was thinking about it too. Maybe it's best to file a JIRA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653993190
**[Test build #125014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125014/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654010051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654644374
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125180/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653944034
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654056075
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654079926
**[Test build #125046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125046/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #28999: [SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #28999:
URL: https://github.com/apache/spark/pull/28999#discussion_r450767742
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1450,8 +1450,7 @@ case class ParseToDate(left: Expression, format: Option[Expression], child: Expr
extends RuntimeReplaceable {
def this(left: Expression, format: Expression) {
- this(left, Option(format),
- Cast(SecondsToTimestamp(UnixTimestamp(left, format)), DateType))
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654054388
**[Test build #125021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125021/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654644368
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653993190
**[Test build #125014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125014/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653973632
**[Test build #124995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124995/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654289725
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125046/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654008663
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654463562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654608665
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125129/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653932103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653931839
**[Test build #124922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124922/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654608654
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654009975
**[Test build #125021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125021/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654462030
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654056075
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654668593
**[Test build #125192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125192/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653931839
**[Test build #124922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124922/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654462894
**[Test build #125129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125129/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653932103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654009975
**[Test build #125021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125021/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654861466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653976760
**[Test build #124995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124995/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654079363
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654608654
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28999: [SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654668593
**[Test build #125192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125192/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653973364
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28999:
URL: https://github.com/apache/spark/pull/28999#discussion_r450519599
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1450,8 +1450,7 @@ case class ParseToDate(left: Expression, format: Option[Expression], child: Expr
extends RuntimeReplaceable {
def this(left: Expression, format: Expression) {
- this(left, Option(format),
- Cast(SecondsToTimestamp(UnixTimestamp(left, format)), DateType))
Review comment:
Hi, @MaxGekk . If you don't mind, please make a JIRA issue for this. That will give us a traceability for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654624692
**[Test build #125180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125180/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653943739
**[Test build #124922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124922/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653993422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653976774
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124995/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654669317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654007490
**[Test build #125014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125014/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654056085
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125021/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654289709
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653976770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653944036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124922/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654624692
**[Test build #125180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125180/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654644082
**[Test build #125180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125180/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654287432
**[Test build #125046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125046/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28999: [SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28999:
URL: https://github.com/apache/spark/pull/28999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654667297
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28999: [SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654858374
**[Test build #125192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125192/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654289709
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654080398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653991735
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654625180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654010051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653973632
**[Test build #124995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124995/testReport)** for PR 28999 at commit [`87a3752`](https://github.com/apache/spark/commit/87a3752e8c93240231e00deea467e63a915ce17a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653973827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654625180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653993422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654623188
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654080398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-654463562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28999:
URL: https://github.com/apache/spark/pull/28999#issuecomment-653973827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org