[GitHub] [dubbo] githublaohu commented on issue #5146: AMS realize dubbo Proxy

["githublaohu (GitHub)" <gi...@apache.org>]

是的，asm兼容性问题值得重点关注，谢谢。
我已经做了大量的单元测试。尽量覆盖所有场景。




    



    
    
    



    
        
            
                
                    
                        
                    
                    
                        
                            2372554140
                            
                            
                                
                                    邮箱：2372554140@qq.com
                                
                        
                    
                
            
        
    


Signature is customized by Netease Mail Master


On 12/13/2019 10:54, hengyunabc wrote: 个人意见：


直接使用asm会让代码非常难看懂，有问题的话，也比较难查。一不小心的话，栈不配平，或者参数没匹配上就会出错。如果有异常处理的话，更是复杂和难理解。


ClassLoader/ClassPath 会有很多的dark corner，已经在Javassist本身里处理掉的。直接用asm可能会遇到



—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/apache/dubbo/pull/5146?email_source=notifications\u0026email_token=ACCGO6V5VJTWJVVEGK3D7D3QYL2PJA5CNFSM4I6P7NL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGYXSII#issuecomment-565279009",
"url": "https://github.com/apache/dubbo/pull/5146?email_source=notifications\u0026email_token=ACCGO6V5VJTWJVVEGK3D7D3QYL2PJA5CNFSM4I6P7NL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGYXSII#issuecomment-565279009",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

[ Full content available at: https://github.com/apache/dubbo/pull/5146 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org