You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/07 03:05:10 UTC

[GitHub] [doris] Kikyou1997 commented on a diff in pull request #11569: [Fix](planner) Fix wrong planner with count(*) optmizer for cross join optimization

Kikyou1997 commented on code in PR #11569:
URL: https://github.com/apache/doris/pull/11569#discussion_r939599726


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SlotDescriptor.java:
##########
@@ -162,6 +162,21 @@ public void setIsMaterialized(boolean value) {
         isMaterialized = value;
     }
 
+    public void materializeSrcExpr() {
+        if (sourceExprs == null) {
+            return;
+        }
+        for (Expr expr : sourceExprs) {

Review Comment:
   Yes, we do need



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org