[jira] [Commented] (TS-3382) Complaints of CRYPTO_set_id_callback while compiling against openssl 1.1

["Susan Hinrichs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369540#comment-14369540 ] 

Susan Hinrichs commented on TS-3382:
------------------------------------

The CRYPTO_THREADID calls replace the CRYPTO_set_id calls. https://www.openssl.org/docs/crypto/threads.html

It looks like the newer calls were introduced in 1.0, so we can probably just roll ahead with the new API for all versions of openssl that we support.

It appears that we use this API to get a thread ID to print in messages generated by SSLDiagnostic.  The old API appears that it would just let us pass the thread ID through.  The new API provides CRYPTO_THREADID_hash(CRYPTO_THREADID *) which creates a unsigned long hash from the thread id structure.  [~sudheerv] and [~briang] is a unique id sufficient for our needs?  Or do we really need to pass the pthread id through for our debugging?



> Complaints of  CRYPTO_set_id_callback while compiling against openssl 1.1
> -------------------------------------------------------------------------
>
>                 Key: TS-3382
>                 URL: https://issues.apache.org/jira/browse/TS-3382
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Susan Hinrichs
>            Assignee: Susan Hinrichs
>             Fix For: 6.0.0
>
>
>  CRYPTO_set_id_callback has been deprecated since openssl 1.0.0.  Should update with the replacing call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)