[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10307: Add support for all partitioing schemes for auto compaction

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on a change in pull request #10307:
URL: https://github.com/apache/druid/pull/10307#discussion_r475111599



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -764,7 +765,28 @@ private PartitionBoundaries determineRangePartition(Collection<StringDistributio
     return Pair.of(start, stop);
   }
 
-  private static void publishSegments(TaskToolbox toolbox, Map<String, PushedSegmentsReport> reportsMap)
+  public static Function<Set<DataSegment>, Set<DataSegment>> compactionStateAnnotateFunction(

Review comment:
       should this rather stay inside `AbstractBatchIndexTask` so that concrete Task classes remain unaware of each other? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org