You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2014/12/18 22:28:32 UTC
[GitHub] couchdb-couch pull request: 1145 local docs handler
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/26
1145 local docs handler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-couch 1145-_local_docs-handler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit a0ad48986bf73449c5ae88d80b573aa3a27ae8a7
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2014-12-16T20:42:28Z
Use namespace argument to select correct tree for the enum_docs request
COUCHDB-1145
commit f253bb52063339412940be1805edcb0b1a703e2e
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2014-12-18T17:45:38Z
Allow chaining of filter functions before we traverse the tree
COUCHDB-1145
commit 9ea89a45b653370dad8fddba00b92c91f933e1db
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2014-12-18T20:20:44Z
Implement namespaced enum_docs (needed for _design_docs)
COUCHDB-1145
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-69665821
/cc @rnewson @chewbranca @davisp
While I found the solution a bit complicated, I see it works and solves the main problem. So I'm happy to merge this and if it will be actual simplify (if it is ever possible) later. But would be also good if you take a look on the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-74664640
added without tests. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-72241690
Looks correct
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-72164608
Nvm, PR for couchdb-couch-mrview wasn't mentioned in COUCHDB-1145, I miss it. Please check if all the correct:
https://github.com/apache/couchdb-documentation/pull/10
https://github.com/apache/couchdb-fabric/pull/8
https://github.com/apache/couchdb-chttpd/pull/16
https://github.com/apache/couchdb/pull/291
https://github.com/apache/couchdb-couch-mrview/pull/13
And this one. 6 in total.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-72164141
I'd plan to merge this branch, but something went wrong and `GET /db/_local_docs` and `GET /db/_design_docs` always returns the same content as `GET /db/_all_docs`. Also, if I remove handlers definition from ini file, these endpoints continue to be available. @iilyak could you check this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-72244237
@iilyak all merged. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-67569899
Have a bad feel about `pipe` code - it looks like too complicated and designed to do more than feature needs for. Is it ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/26#issuecomment-74721828
@rnewson nothing is forgotten. will be added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 1145 local docs handler
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---