You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/05/05 19:42:08 UTC
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/74
CB-8946: Added the "WindowsToastCapable" preference
Added the "WindowsToastCapable" preference to indicate that the app can support toasts. This is to support the Local Notifications plugin. See https://issues.apache.org/jira/browse/CB-8946
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-8946
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 5f72b571ebabd1924049f544fc6bfe4a554ae4fc
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-05-05T17:40:27Z
CB-8946: Added the "WindowsToastCapable" preference to indicate that the
app can support toasts. This is to support the Local Notifications
plugin.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/74#issuecomment-99159134
This should be done by the Local Notification plugin itself shouldn't it?
-1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/74#issuecomment-99278002
Okay, we can merge this. I will file an issue to fix plugman also.
I would much rather if we could just go:
```<config-file target="package.phone.appxmanifest" parent="/Package/Applications/Application/m3:VisualElements[@ToastCapable]">true</config-file>
<config-file target="package.windows.appxmanifest" parent="/Package/Applications/Application/m3:VisualElements[@ToastCapable]">true</config-file>
<config-file target="package.windows80.appxmanifest" parent="/Package/Applications/Application/m3:VisualElements[@ToastCapable]">true</config-file>```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/74#issuecomment-99556720
If you decide to use the `preference` approach - make sure you document it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/74#issuecomment-99160167
The plugin is likely unable to do this directly except via hooks, because the `<config-file>` directive is an element-level change, but the modification is at an attribute-level (Application/VisualElements@ToastCapable)
We have several preferences that modify the attributes of the VisualElements tag. Plugins can specify elements become descendants of other elements in package.appxmanifest, but AFAIK they can't say "there's an existing element, set this attribute of that element" and have it respected by plugman.
Making such a change to plugman seems much larger and more invasive than creating a preference like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/74#issuecomment-103980396
@robpaveza Has this been documented?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org