You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/11/15 09:00:14 UTC
[jira] [Created] (WICKET-4867) Detach the object before calculating
its size
Martin Grigorov created WICKET-4867:
---------------------------------------
Summary: Detach the object before calculating its size
Key: WICKET-4867
URL: https://issues.apache.org/jira/browse/WICKET-4867
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5.9, 6.2.0
Reporter: Martin Grigorov
Assignee: Martin Grigorov
Priority: Minor
The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
the size of the page and the session.
The "problem" that I see is that it calculates the size of the non-detached
object. I think what really matters is the size after detaching it, because
this is what is being saved in the http session and the disk, and I guess
this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WICKET-4867) Detach the object before calculating
its size
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier closed WICKET-4867.
------------------------------
Resolution: Fixed
With WICKET-4878 FeedbackPanel is no longer in need of the missing messages.
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.5.10, 6.3.0
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4867) Detach the object before
calculating its size
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501980#comment-13501980 ]
Sven Meier commented on WICKET-4867:
------------------------------------
I'm looking at WicketExamplePage->WicketExampleHeader. FormInput adds a Feedback later on.
But even moving the DebugBar to the end of the page doesn't help.
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.3.0, 1.5.10
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4867) Detach the object before
calculating its size
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier reopened WICKET-4867:
--------------------------------
This breaks FeedbackMessages when PageSizeDebugPanel calculates component sizes.
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.3.0, 1.5.10
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-4867) Detach the object before
calculating its size
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501980#comment-13501980 ]
Sven Meier edited comment on WICKET-4867 at 11/21/12 3:06 PM:
--------------------------------------------------------------
I'm looking at WicketExamplePage->WicketExampleHeader. FormInput adds a Feedback later on.
We'll have to move <span wicket:id="mainNavigation"/> down in all markups :/.
was (Author: svenmeier):
I'm looking at WicketExamplePage->WicketExampleHeader. FormInput adds a Feedback later on.
But even moving the DebugBar to the end of the page doesn't help.
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.3.0, 1.5.10
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4867) Detach the object before
calculating its size
Posted by "Ernesto Reinaldo Barreiro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501987#comment-13501987 ]
Ernesto Reinaldo Barreiro commented on WICKET-4867:
---------------------------------------------------
Maybe debug bar should be reworked in way that it does't matter where it is "placed". Something on the lines
1-Via some "listener" call WicketObjects.sizeOf() at the end of the request cycle.
2-Put resulting size info (some how) on response.
3-Debug bar reads this info from response (on client).
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.3.0, 1.5.10
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4867) Detach the object before
calculating its size
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501932#comment-13501932 ]
Sven Meier commented on WICKET-4867:
------------------------------------
A detached component loses all rendered FeedbackMassages. Note that FeedbackMessages are marked rendered in FeedbackPanel$MessageListView#polpulateItem() already. During rendering the access to the FeedbackMessage fails because it is already removed.
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.3.0, 1.5.10
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4867) Detach the object before
calculating its size
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4867.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.10
6.3.0
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.3.0, 1.5.10
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4867) Detach the object before
calculating its size
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501971#comment-13501971 ]
Martin Grigorov commented on WICKET-4867:
-----------------------------------------
Is PageSizeDebugPanel rendered before your feedback panel ?
As discussed in the mail thread any debug panel that uses WicketObjects.sizeOf() should be placed after other components which do something meaningful in their #detach(). In the thread LoadableDetachableModel is used as example but the case is the same.
> Detach the object before calculating its size
> ---------------------------------------------
>
> Key: WICKET-4867
> URL: https://issues.apache.org/jira/browse/WICKET-4867
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.2.0, 1.5.9
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 6.3.0, 1.5.10
>
>
> The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
> the size of the page and the session.
> The "problem" that I see is that it calculates the size of the non-detached
> object. I think what really matters is the size after detaching it, because
> this is what is being saved in the http session and the disk, and I guess
> this is what the developer needs to know actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira