You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by ChinmaySKulkarni <gi...@git.apache.org> on 2018/11/10 03:24:07 UTC

[GitHub] phoenix pull request #403: PHOENIX-5008: CQSI.init should not bubble up Retr...

GitHub user ChinmaySKulkarni opened a pull request:

    https://github.com/apache/phoenix/pull/403

    PHOENIX-5008: CQSI.init should not bubble up RetriableUpgradeException to client in case of an UpgradeRequiredException

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-5008

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #403
    
----
commit edd483072fa5748325f53f8dccf8281390b0f48c
Author: Chinmay Kulkarni <ch...@...>
Date:   2018-11-10T03:22:57Z

    PHOENIX-5008: CQSI.init should not bubble up RetriableUpgradeException to client in case of an UpgradeRequiredException

----


---

[GitHub] phoenix issue #403: PHOENIX-5008: CQSI.init should not bubble up RetriableUp...

Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni commented on the issue:

    https://github.com/apache/phoenix/pull/403
  
    Please review @twdsilva @aaraujo 


---

[GitHub] phoenix pull request #403: PHOENIX-5008: CQSI.init should not bubble up Retr...

Posted by twdsilva <gi...@git.apache.org>.
Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/403#discussion_r232861770
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java ---
    @@ -428,14 +433,78 @@ public void testMetadataAlterRemainsAutoUpgradeEnabled() throws Exception {
             assertEquals(Integer.parseInt(MODIFIED_MAX_VERSIONS), verifyModificationTableMetadata(driver, PHOENIX_SYSTEM_CATALOG));
         }
     
    +    // Test the case when an end-user uses the vanilla PhoenixDriver to create a connection and a
    +    // requirement for upgrade is detected. In this case, the user should get a connection on which
    +    // they are only able to run "EXECUTE UPGRADE"
    +    @Test
    +    public void testExecuteUpgradeSameConnWithPhoenixDriver() throws Exception {
    +        // Register the vanilla PhoenixDriver
    +        DriverManager.registerDriver(PhoenixDriver.INSTANCE);
    --- End diff --
    
    Spoke with @ChinmaySKulkarni  offline, looks like we need to run the other tests with a test driver to verify execute upgrade is called the expected number of times. 
    +1 LGTM


---

[GitHub] phoenix pull request #403: PHOENIX-5008: CQSI.init should not bubble up Retr...

Posted by twdsilva <gi...@git.apache.org>.
Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/403#discussion_r232851836
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java ---
    @@ -428,14 +433,78 @@ public void testMetadataAlterRemainsAutoUpgradeEnabled() throws Exception {
             assertEquals(Integer.parseInt(MODIFIED_MAX_VERSIONS), verifyModificationTableMetadata(driver, PHOENIX_SYSTEM_CATALOG));
         }
     
    +    // Test the case when an end-user uses the vanilla PhoenixDriver to create a connection and a
    +    // requirement for upgrade is detected. In this case, the user should get a connection on which
    +    // they are only able to run "EXECUTE UPGRADE"
    +    @Test
    +    public void testExecuteUpgradeSameConnWithPhoenixDriver() throws Exception {
    +        // Register the vanilla PhoenixDriver
    +        DriverManager.registerDriver(PhoenixDriver.INSTANCE);
    --- End diff --
    
    Can we just move this to @BeforeClass so that all the tests run with the real driver?


---

[GitHub] phoenix pull request #403: PHOENIX-5008: CQSI.init should not bubble up Retr...

Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni closed the pull request at:

    https://github.com/apache/phoenix/pull/403


---

[GitHub] phoenix pull request #403: PHOENIX-5008: CQSI.init should not bubble up Retr...

Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/403#discussion_r233278355
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogCreationOnConnectionIT.java ---
    @@ -428,14 +433,78 @@ public void testMetadataAlterRemainsAutoUpgradeEnabled() throws Exception {
             assertEquals(Integer.parseInt(MODIFIED_MAX_VERSIONS), verifyModificationTableMetadata(driver, PHOENIX_SYSTEM_CATALOG));
         }
     
    +    // Test the case when an end-user uses the vanilla PhoenixDriver to create a connection and a
    +    // requirement for upgrade is detected. In this case, the user should get a connection on which
    +    // they are only able to run "EXECUTE UPGRADE"
    +    @Test
    +    public void testExecuteUpgradeSameConnWithPhoenixDriver() throws Exception {
    +        // Register the vanilla PhoenixDriver
    +        DriverManager.registerDriver(PhoenixDriver.INSTANCE);
    --- End diff --
    
    Thanks for the review @twdsilva.


---