[GitHub] [incubator-iceberg] rdblue commented on issue #654: Move identifier validation into BaseMetastoreCatalog

[GitBox <gi...@apache.org>]

rdblue commented on issue #654: Move identifier validation into BaseMetastoreCatalog
URL: https://github.com/apache/incubator-iceberg/pull/654#issuecomment-555623863
 
 
   > tableExists in Iceberg and Spark catalogs is implemented in a way that will swallow the exception and simply report false
   
   I think that's the expected behavior. That's why I updated this to throw `NoSuchTableException`. Shouldn't `tableExists` always return a boolean and not throw a `ValidationException`? I think users expect `tableExists` to be safe if they pass in an identifier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org