[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

[GitBox <gi...@apache.org>]

ephraimbuddy commented on code in PR #28619:
URL: https://github.com/apache/airflow/pull/28619#discussion_r1061476099


##########
airflow/api/client/json_client.py:
##########
@@ -24,9 +24,24 @@
 
 
 class Client(api_client.Client):
-    """Json API client implementation."""
+    """Json API client implementation.
 
-    def _request(self, url, method="GET", json=None):
+    This client is used to interact with a Json API server and perform various actions
+    such as triggering DAG runs,deleting DAGs, interacting with pools, and getting lineage information.
+
+    :param api_base_url: The base URL for the Json API server.
+    :param session: A session object to use for making HTTP requests.

Review Comment:
   Is the `api_base_url` and `session` necessary here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org