You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Serge Knystautas (JIRA)" <ji...@apache.org> on 2006/03/04 21:57:40 UTC
[jira] Created: (VELOCITY-433) Replace parser pool
Replace parser pool
-------------------
Key: VELOCITY-433
URL: http://issues.apache.org/jira/browse/VELOCITY-433
Project: Velocity
Type: Improvement
Components: Source
Reporter: Serge Knystautas
Priority: Minor
You cannot configure a class that does parser pooling, which makes it hard to balance between the # of instances to pool and the amount of heap space you're committing to velocity.
This patch refactors the parser pooling logic so that it behaves with a typical pool and parser factory concept. The existing pool implementation class is left untouched and is wrapped by the new default class that implements the new ParserPool interface.
Behavior and benchmark appears consistent. Tried to format code correctly, but probably missed some spots. One patch file and 2 new java files. Will attach shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Updated: (VELOCITY-433) Replace parser pool
Posted by "Serge Knystautas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-433?page=all ]
Serge Knystautas updated VELOCITY-433:
--------------------------------------
Attachment: pool-parsers.txt
ParserPool.java
ParserPoolImpl.java
> Replace parser pool
> -------------------
>
> Key: VELOCITY-433
> URL: http://issues.apache.org/jira/browse/VELOCITY-433
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Serge Knystautas
> Priority: Minor
> Attachments: ParserPool.java, ParserPoolImpl.java, pool-parsers.txt
>
> You cannot configure a class that does parser pooling, which makes it hard to balance between the # of instances to pool and the amount of heap space you're committing to velocity.
> This patch refactors the parser pooling logic so that it behaves with a typical pool and parser factory concept. The existing pool implementation class is left untouched and is wrapped by the new default class that implements the new ParserPool interface.
> Behavior and benchmark appears consistent. Tried to format code correctly, but probably missed some spots. One patch file and 2 new java files. Will attach shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELOCITY-433) Replace parser pool
Posted by "Serge Knystautas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-433?page=comments#action_12369006 ]
Serge Knystautas commented on VELOCITY-433:
-------------------------------------------
Yup, ant test ran fine.
> Replace parser pool
> -------------------
>
> Key: VELOCITY-433
> URL: http://issues.apache.org/jira/browse/VELOCITY-433
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Serge Knystautas
> Priority: Minor
> Attachments: ParserPool.java, ParserPoolImpl.java, pool-parsers.txt
>
> You cannot configure a class that does parser pooling, which makes it hard to balance between the # of instances to pool and the amount of heap space you're committing to velocity.
> This patch refactors the parser pooling logic so that it behaves with a typical pool and parser factory concept. The existing pool implementation class is left untouched and is wrapped by the new default class that implements the new ParserPool interface.
> Behavior and benchmark appears consistent. Tried to format code correctly, but probably missed some spots. One patch file and 2 new java files. Will attach shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Closed: (VELOCITY-433) Replace parser pool
Posted by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen closed VELOCITY-433.
-------------------------------------------
> Replace parser pool
> -------------------
>
> Key: VELOCITY-433
> URL: https://issues.apache.org/jira/browse/VELOCITY-433
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Reporter: Serge Knystautas
> Priority: Minor
> Fix For: 1.5
>
> Attachments: ParserPool.java, ParserPoolImpl.java, pool-parsers.txt
>
>
> You cannot configure a class that does parser pooling, which makes it hard to balance between the # of instances to pool and the amount of heap space you're committing to velocity.
> This patch refactors the parser pooling logic so that it behaves with a typical pool and parser factory concept. The existing pool implementation class is left untouched and is wrapped by the new default class that implements the new ParserPool interface.
> Behavior and benchmark appears consistent. Tried to format code correctly, but probably missed some spots. One patch file and 2 new java files. Will attach shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELOCITY-433) Replace parser pool
Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-433?page=all ]
Will Glass-Husain resolved VELOCITY-433:
----------------------------------------
Fix Version: 1.5
Resolution: Fixed
Patch applied. Nice idea and implementation. Thanks for contributing!
> Replace parser pool
> -------------------
>
> Key: VELOCITY-433
> URL: http://issues.apache.org/jira/browse/VELOCITY-433
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Serge Knystautas
> Priority: Minor
> Fix For: 1.5
> Attachments: ParserPool.java, ParserPoolImpl.java, pool-parsers.txt
>
> You cannot configure a class that does parser pooling, which makes it hard to balance between the # of instances to pool and the amount of heap space you're committing to velocity.
> This patch refactors the parser pooling logic so that it behaves with a typical pool and parser factory concept. The existing pool implementation class is left untouched and is wrapped by the new default class that implements the new ParserPool interface.
> Behavior and benchmark appears consistent. Tried to format code correctly, but probably missed some spots. One patch file and 2 new java files. Will attach shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELOCITY-433) Replace parser pool
Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-433?page=comments#action_12368923 ]
Will Glass-Husain commented on VELOCITY-433:
--------------------------------------------
Fabulous. Did "ant test" pass?
> Replace parser pool
> -------------------
>
> Key: VELOCITY-433
> URL: http://issues.apache.org/jira/browse/VELOCITY-433
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Serge Knystautas
> Priority: Minor
> Attachments: ParserPool.java, ParserPoolImpl.java, pool-parsers.txt
>
> You cannot configure a class that does parser pooling, which makes it hard to balance between the # of instances to pool and the amount of heap space you're committing to velocity.
> This patch refactors the parser pooling logic so that it behaves with a typical pool and parser factory concept. The existing pool implementation class is left untouched and is wrapped by the new default class that implements the new ParserPool interface.
> Behavior and benchmark appears consistent. Tried to format code correctly, but probably missed some spots. One patch file and 2 new java files. Will attach shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org