You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by re...@apache.org on 2015/08/26 22:51:58 UTC
[1/2] git commit: updated refs/heads/master to eb60ac9
Repository: cloudstack
Updated Branches:
refs/heads/master cc9c86859 -> eb60ac976
Removing unit test that was covering the resolution of the nano time
- The difference between 2 consecultive calls to System.nanoTime() returns a resolution that depends on the OS implementation. Due to that, the test was failing in an inttermmitent manner
- Today we decided to remove the test since it was not testing a direct feature of ACS
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/d74d1346
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/d74d1346
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/d74d1346
Branch: refs/heads/master
Commit: d74d134698ce381b5d18d6c71815f5042ffd1816
Parents: cc9c868
Author: wilderrodrigues <wr...@schubergphilis.com>
Authored: Wed Aug 26 19:25:47 2015 +0200
Committer: wilderrodrigues <wr...@schubergphilis.com>
Committed: Wed Aug 26 20:00:59 2015 +0200
----------------------------------------------------------------------
.../test/java/com/cloud/utils/TestProfiler.java | 17 -----------------
1 file changed, 17 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/d74d1346/utils/src/test/java/com/cloud/utils/TestProfiler.java
----------------------------------------------------------------------
diff --git a/utils/src/test/java/com/cloud/utils/TestProfiler.java b/utils/src/test/java/com/cloud/utils/TestProfiler.java
index 2306cd7..25b6518 100644
--- a/utils/src/test/java/com/cloud/utils/TestProfiler.java
+++ b/utils/src/test/java/com/cloud/utils/TestProfiler.java
@@ -96,21 +96,4 @@ public class TestProfiler extends Log4jEnabledTestCase {
Assert.assertTrue(pf.getDurationInMillis() == -1);
Assert.assertFalse(pf.isStopped());
}
-
- @Test
- public void testResolution() {
- long nanoTime1 = 0l;
- long nanoTime2 = 0l;
- nanoTime1 = System.nanoTime();
- nanoTime2 = System.nanoTime();
-
- // Using sysout here because is faster than the logger and we don't want to
- // waste time.
- System.out.println("Nano time 1: " + nanoTime1);
- System.out.println("Nano time 2: " + nanoTime2);
-
- // We are measuring the elapsed time in 2 consecutive calls of System.nanoTime()
- // That's the same as 0.002 milliseconds or 2000 nanoseconds.
- Assert.assertTrue("Expected exactly 2 but it took more than 3 microseconds between 2 consecutive calls to System.nanoTime().", nanoTime2 - nanoTime1 <= 3000);
- }
}
\ No newline at end of file
[2/2] git commit: updated refs/heads/master to eb60ac9
Posted by re...@apache.org.
Merge pull request #747 from schubergphilis/fix/broken_profiler_unit_test
Removing unit test that was failing to cover the resolution of the nano time - The difference between 2 consecutive calls to System.nanoTime() returns a resolution that depends on the OS implementation. Due to that, the test was failing in an intermittent manner.
- Today we decided to remove the test since it was not testing a direct feature of ACS
I did not create an issue on Jira because it's only about removing an unit test. There is no bug fix involved or feature developed.
@miguelaferreira @remibergsma @bhaisaab @DaanHoogland
Could you have a look at this change, please?
Cheers,
Wilder
* pr/747:
Removing unit test that was covering the resolution of the nano time
Signed-off-by: Remi Bergsma <gi...@remi.nl>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/eb60ac97
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/eb60ac97
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/eb60ac97
Branch: refs/heads/master
Commit: eb60ac976b99fd8c33a09288e32dc3696ad27a53
Parents: cc9c868 d74d134
Author: Remi Bergsma <gi...@remi.nl>
Authored: Wed Aug 26 22:50:05 2015 +0200
Committer: Remi Bergsma <gi...@remi.nl>
Committed: Wed Aug 26 22:50:06 2015 +0200
----------------------------------------------------------------------
.../test/java/com/cloud/utils/TestProfiler.java | 17 -----------------
1 file changed, 17 deletions(-)
----------------------------------------------------------------------