You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/05 09:40:29 UTC

[GitHub] [dubbo] AlbumenJ opened a new pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

AlbumenJ opened a new pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684


   ## What is the purpose of the change
   
   - Introduce ServiceMetadata for Triple Health check
   - Reintroduce some method
   - Refactor ServiceRepository
   - Support Consumer Param override
   - Support multi consumer
   
   ## Brief changelog
   
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [ ] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (294f327) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **decrease** coverage by `0.12%`.
   > The diff coverage is `65.49%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   - Coverage     63.66%   63.53%   -0.13%     
   + Complexity      311      310       -1     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    48059     +244     
     Branches       7162     7222      +60     
   ============================================
   + Hits          30441    30535      +94     
   - Misses        14013    14132     +119     
   - Partials       3361     3392      +31     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `52.17% <0.00%> (-3.39%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `63.73% <0.00%> (+0.18%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...stry/client/ServiceDiscoveryRegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeVJlZ2lzdHJ5RGlyZWN0b3J5LmphdmE=) | `45.98% <27.27%> (-2.22%)` | :arrow_down: |
   | [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.65% <57.14%> (-6.04%)` | :arrow_down: |
   | ... and [101 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...294f327](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d8c25d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **decrease** coverage by `0.05%`.
   > The diff coverage is `68.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   - Coverage     63.66%   63.61%   -0.06%     
   + Complexity      311      310       -1     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    48038     +223     
     Branches       7162     7219      +57     
   ============================================
   + Hits          30441    30558     +117     
   - Misses        14013    14101      +88     
   - Partials       3361     3379      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `52.17% <0.00%> (-3.39%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `63.73% <0.00%> (+0.18%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `64.04% <63.46%> (-7.70%)` | :arrow_down: |
   | [...a/org/apache/dubbo/config/ReferenceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnQmFzZS5qYXZh) | `71.09% <66.66%> (-0.22%)` | :arrow_down: |
   | ... and [100 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...6d8c25d](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d8c25d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **increase** coverage by `0.02%`.
   > The diff coverage is `68.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   + Coverage     63.66%   63.69%   +0.02%     
   - Complexity      311      312       +1     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    48038     +223     
     Branches       7162     7241      +79     
   ============================================
   + Hits          30441    30597     +156     
   - Misses        14013    14073      +60     
   - Partials       3361     3368       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `52.17% <0.00%> (-3.39%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `63.73% <0.00%> (+0.18%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `64.04% <63.46%> (-7.70%)` | :arrow_down: |
   | [...a/org/apache/dubbo/config/ReferenceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnQmFzZS5qYXZh) | `71.09% <66.66%> (-0.22%)` | :arrow_down: |
   | ... and [92 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...6d8c25d](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d8c25d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **increase** coverage by `0.15%`.
   > The diff coverage is `68.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   + Coverage     63.66%   63.81%   +0.15%     
   - Complexity      311      312       +1     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    48038     +223     
     Branches       7162     7241      +79     
   ============================================
   + Hits          30441    30657     +216     
   - Misses        14013    14017       +4     
   - Partials       3361     3364       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `52.17% <0.00%> (-3.39%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `63.73% <0.00%> (+0.18%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `64.04% <63.46%> (-7.70%)` | :arrow_down: |
   | [...a/org/apache/dubbo/config/ReferenceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnQmFzZS5qYXZh) | `71.09% <66.66%> (-0.22%)` | :arrow_down: |
   | ... and [102 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...6d8c25d](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d8c25d) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **increase** coverage by `0.15%`.
   > The diff coverage is `68.06%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   + Coverage     63.66%   63.82%   +0.15%     
   - Complexity      311      313       +2     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    48038     +223     
     Branches       7162     7241      +79     
   ============================================
   + Hits          30441    30658     +217     
   - Misses        14013    14017       +4     
   - Partials       3361     3363       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `52.17% <0.00%> (-3.39%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `63.73% <0.00%> (+0.18%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `64.04% <63.46%> (-7.70%)` | :arrow_down: |
   | [...a/org/apache/dubbo/config/ReferenceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvUmVmZXJlbmNlQ29uZmlnQmFzZS5qYXZh) | `71.09% <66.66%> (-0.22%)` | :arrow_down: |
   | ... and [102 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...6d8c25d](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (294f327) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **decrease** coverage by `0.00%`.
   > The diff coverage is `65.49%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   - Coverage     63.66%   63.65%   -0.01%     
   - Complexity      311      313       +2     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    48059     +244     
     Branches       7162     7244      +82     
   ============================================
   + Hits          30441    30592     +151     
   - Misses        14013    14090      +77     
   - Partials       3361     3377      +16     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `52.17% <0.00%> (-3.39%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `63.73% <0.00%> (+0.18%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...stry/client/ServiceDiscoveryRegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeVJlZ2lzdHJ5RGlyZWN0b3J5LmphdmE=) | `45.98% <27.27%> (-2.22%)` | :arrow_down: |
   | [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.65% <57.14%> (-6.04%)` | :arrow_down: |
   | ... and [95 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...294f327](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78c20b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **decrease** coverage by `0.05%`.
   > The diff coverage is `64.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   - Coverage     63.66%   63.61%   -0.06%     
   - Complexity      311      313       +2     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    47964     +149     
     Branches       7162     7199      +37     
   ============================================
   + Hits          30441    30511      +70     
   - Misses        14013    14088      +75     
   - Partials       3361     3365       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `50.00% <0.00%> (-5.56%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `62.88% <0.00%> (-0.67%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `59.42% <46.15%> (-12.32%)` | :arrow_down: |
   | [...n/java/org/apache/dubbo/rpc/model/ModuleModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlTW9kZWwuamF2YQ==) | `71.42% <66.66%> (-6.35%)` | :arrow_down: |
   | ... and [64 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...c78c20b](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8684: [3.0] Multi Instances - Refactor ServiceRepository

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8684:
URL: https://github.com/apache/dubbo/pull/8684#issuecomment-913128348


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8684](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78c20b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7c8662e99ebdcc66f08d089bc3e7493e4d2d89cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c8662e) will **decrease** coverage by `0.07%`.
   > The diff coverage is `64.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8684/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8684      +/-   ##
   ============================================
   - Coverage     63.66%   63.58%   -0.08%     
   - Complexity      311      312       +1     
   ============================================
     Files          1141     1142       +1     
     Lines         47815    47964     +149     
     Branches       7162     7199      +37     
   ============================================
   + Hits          30441    30500      +59     
   - Misses        14013    14094      +81     
   - Partials       3361     3370       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvUHJvdmlkZXJNb2RlbC5qYXZh) | `38.23% <0.00%> (-5.84%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `75.60% <0.00%> (-24.40%)` | :arrow_down: |
   | [.../java/org/apache/dubbo/rpc/model/ServiceModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZU1vZGVsLmphdmE=) | `50.00% <0.00%> (-5.56%)` | :arrow_down: |
   | [.../org/apache/dubbo/rpc/model/ServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `70.83% <ø> (+1.44%)` | :arrow_up: |
   | [...bo/rpc/service/ServiceDescriptorInternalCache.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvc2VydmljZS9TZXJ2aWNlRGVzY3JpcHRvckludGVybmFsQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/qos/probe/impl/ProviderReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvUHJvdmlkZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `62.88% <0.00%> (-0.67%)` | :arrow_down: |
   | [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `39.13% <11.11%> (-4.12%)` | :arrow_down: |
   | [...pache/dubbo/rpc/model/ModuleServiceRepository.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlU2VydmljZVJlcG9zaXRvcnkuamF2YQ==) | `59.42% <46.15%> (-12.32%)` | :arrow_down: |
   | [...n/java/org/apache/dubbo/rpc/model/ModuleModel.java](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvTW9kdWxlTW9kZWwuamF2YQ==) | `71.42% <66.66%> (-6.35%)` | :arrow_down: |
   | ... and [63 more](https://codecov.io/gh/apache/dubbo/pull/8684/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c8662e...c78c20b](https://codecov.io/gh/apache/dubbo/pull/8684?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org