You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2011/02/27 03:45:37 UTC
svn commit: r1074977 - in /commons/proper/net/trunk/src: changes/changes.xml
main/java/org/apache/commons/net/pop3/POP3MessageInfo.java
Author: sebb
Date: Sun Feb 27 02:45:37 2011
New Revision: 1074977
URL: http://svn.apache.org/viewvc?rev=1074977&view=rev
Log:
NET-317 POP3MessageInfo fields should be final
Modified:
commons/proper/net/trunk/src/changes/changes.xml
commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3MessageInfo.java
Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1074977&r1=1074976&r2=1074977&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml (original)
+++ commons/proper/net/trunk/src/changes/changes.xml Sun Feb 27 02:45:37 2011
@@ -1,19 +1,21 @@
<?xml version="1.0"?>
<!--
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to You under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
-->
<!--
This file is also used by the maven-changes-plugin to generate the release notes.
@@ -51,7 +53,10 @@ The <action> type attribute can be add,u
-->
<body>
- <release version="2.3" date="TBA" description="TBA">
+ <release version="3.0" date="TBA" description="TBA">
+ <action issue="NET-317" dev="sebb" type="fix">
+ POP3MessageInfo fields should be final.
+ </action>
<action issue="NET-252" dev="sebb" type="fix">
Get rid of using deprecated API in VMSFTPEntryParser.
</action>
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3MessageInfo.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3MessageInfo.java?rev=1074977&r1=1074976&r2=1074977&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3MessageInfo.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3MessageInfo.java Sun Feb 27 02:45:37 2011
@@ -41,10 +41,9 @@ package org.apache.commons.net.pop3;
public final class POP3MessageInfo
{
- // TODO - make these fields final? They are all set on construction
- public int number;
- public int size;
- public String identifier;
+ public final int number;
+ public final int size;
+ public final String identifier;
/***
* Creates a POP3MessageInfo instance with <code>number</code> and