You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Victor J. Orlikowski" <v....@gte.net> on 2000/08/31 19:27:49 UTC

[PATCH] Add ability for DSO specific linker flags

This patch is being submitted so that we can pass specific options to
modules being compiled as DSOs. The libtool that we are now using does
not support being passed arbitrary linker flags, but one that does is due
out soon, and we will need this for DSOs on AIX. 

Index: src/acinclude.m4
===================================================================
RCS file: /cvs/apache/apache-2.0/src/acinclude.m4,v
retrieving revision 1.44
diff -u -r1.44 acinclude.m4
--- acinclude.m4	2000/08/11 04:13:43	1.44
+++ acinclude.m4	2000/08/31 17:15:49
@@ -71,6 +71,7 @@
   APACHE_SUBST(CXXFLAGS)
   APACHE_SUBST(LTFLAGS)
   APACHE_SUBST(LDFLAGS)
+  APACHE_SUBST(SH_LDFLAGS)
   APACHE_SUBST(DEFS)
   APACHE_SUBST(LIBTOOL)
   APACHE_SUBST(SHELL)
Index: src/build/rules.mk
===================================================================
RCS file: /cvs/apache/apache-2.0/src/build/rules.mk,v
retrieving revision 1.25
diff -u -r1.25 rules.mk
--- rules.mk	2000/08/19 00:34:38	1.25
+++ rules.mk	2000/08/31 17:15:50
@@ -71,7 +71,7 @@
 # Link-related commands
 
 LINK    = $(LIBTOOL) --mode=link $(COMPILE) $(LTFLAGS) $(LDFLAGS) -o $@
-SH_LINK = $(SH_LIBTOOL) --mode=link $(COMPILE) $(LTFLAGS) $(LDFLAGS) -o $@
+SH_LINK = $(SH_LIBTOOL) --mode=link $(COMPILE) $(LTFLAGS) $(LDFLAGS) $(SH_LDFLAGS) -o $@
 
 # Helper programs

Victor
-- 
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com


Re: [PATCH] Add ability for DSO specific linker flags

Posted by "Victor J. Orlikowski" <v....@gte.net>.
SH_LDFLAGS was to be set RSN in hints.m4.
APACHE_SUBST(SH_LDFLAGS) is needed to place SH_LDFLAGS in config_vars.mk,
whereupon it is used for compilation thereafter.

Victor
-- 
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com



Re: [PATCH] Add ability for DSO specific linker flags

Posted by Jeff Trawick <tr...@bellsouth.net>.
"Victor J. Orlikowski" <v....@gte.net> writes:

> This patch is being submitted so that we can pass specific options to
> modules being compiled as DSOs. The libtool that we are now using does
> not support being passed arbitrary linker flags, but one that does is due
> out soon, and we will need this for DSOs on AIX. 
> 
> Index: src/acinclude.m4
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/acinclude.m4,v
> retrieving revision 1.44
> diff -u -r1.44 acinclude.m4
> --- acinclude.m4	2000/08/11 04:13:43	1.44
> +++ acinclude.m4	2000/08/31 17:15:49
> @@ -71,6 +71,7 @@
>    APACHE_SUBST(CXXFLAGS)
>    APACHE_SUBST(LTFLAGS)
>    APACHE_SUBST(LDFLAGS)
> +  APACHE_SUBST(SH_LDFLAGS)

Ummm... SH_LDFLAGS is never used as a variable in a template (whatever
you call the use of @LDFLAGS@ in lib/apr/test/Makefile.in), so you
don't need to APACHE_SUBST(SH_LDFLAGS) (I'll be happy to be proven
wrong, but that's my understanding).

>    APACHE_SUBST(DEFS)
>    APACHE_SUBST(LIBTOOL)
>    APACHE_SUBST(SHELL)
> Index: src/build/rules.mk
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/build/rules.mk,v
> retrieving revision 1.25
> diff -u -r1.25 rules.mk
> --- rules.mk	2000/08/19 00:34:38	1.25
> +++ rules.mk	2000/08/31 17:15:50
> @@ -71,7 +71,7 @@
>  # Link-related commands
>  
>  LINK    = $(LIBTOOL) --mode=link $(COMPILE) $(LTFLAGS) $(LDFLAGS) -o $@
> -SH_LINK = $(SH_LIBTOOL) --mode=link $(COMPILE) $(LTFLAGS) $(LDFLAGS) -o $@
> +SH_LINK = $(SH_LIBTOOL) --mode=link $(COMPILE) $(LTFLAGS) $(LDFLAGS) $(SH_LDFLAGS) -o $@

Where is SH_LDFLAGS ever set?  Did you intend to post a change to
hints.m4 or configure.in or something to set SH_LDFLAGS on AIX?

Thanks,

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...