You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jd...@apache.org on 2006/10/24 23:50:55 UTC

svn commit: r467499 - /geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/StartServerMojo.java

Author: jdillon
Date: Tue Oct 24 14:50:54 2006
New Revision: 467499

URL: http://svn.apache.org/viewvc?view=rev&rev=467499
Log:
Just log a warning when an option is specified by no optionSet was defined... instead of failing

Modified:
    geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/StartServerMojo.java

Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/StartServerMojo.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/StartServerMojo.java?view=diff&rev=467499&r1=467498&r2=467499
==============================================================================
--- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/StartServerMojo.java (original)
+++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/StartServerMojo.java Tue Oct 24 14:50:54 2006
@@ -34,7 +34,6 @@
 import org.apache.maven.plugin.MojoExecutionException;
 
 import org.apache.tools.ant.taskdefs.Java;
-import org.apache.tools.ant.types.Environment;
 
 import org.apache.geronimo.genesis.util.ObjectHolder;
 import org.apache.geronimo.mavenplugins.geronimo.ServerProxy;
@@ -349,7 +348,7 @@
                     log.debug("Default optionSet selected, but no optionSet defined with that id; ignoring");
                 }
                 else {
-                    throw new MojoExecutionException("Missing optionSet for id: " + id);
+                    log.warn("Missing optionSet for id: " + id);
                 }
             }
             else {
@@ -362,8 +361,9 @@
 
     protected String getGoalName() {
         //
-        //FIXME: There has to be way this can be computed instead of hardcoded absolutely.
+        // FIXME: There has to be way this can be computed instead of hardcoded absolutely.
         //
+        
         return "start-server";
     }
 }