You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/23 08:17:16 UTC
[GitHub] [maven] michael-o opened a new pull request, #934: [MNG-7352] org.apache.maven.toolchain.java.JavaToolchainImpl should b…
michael-o opened a new pull request, #934:
URL: https://github.com/apache/maven/pull/934
…e public
This closes #934
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #934: [MNG-7352] org.apache.maven.toolchain.java.JavaToolchainImpl should b…
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #934:
URL: https://github.com/apache/maven/pull/934#issuecomment-1363724246
@bananeweizen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] Bananeweizen commented on pull request #934: [MNG-7352] org.apache.maven.toolchain.java.JavaToolchainImpl should b…
Posted by GitBox <gi...@apache.org>.
Bananeweizen commented on PR #934:
URL: https://github.com/apache/maven/pull/934#issuecomment-1364178304
To me this looks good. Regarding the question how this is used: https://github.com/eclipse-tycho/tycho/blob/4e3f31c4411156c86a8571e353efde898cf258ea/tycho-compiler-plugin/src/main/java/org/eclipse/tycho/compiler/AbstractOsgiCompilerMojo.java#L777 shows Tycho calling `getJavaHome()` on that class, which is not available in the super interface, otherwise we wouldn't need to look at this class.
I'm not sure whether I should also comment in the Jira issue (is there any transition of Maven projects to Github ongoing or was it always this kind of mixed for issues and pull requests?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #934: [MNG-7352] org.apache.maven.toolchain.java.JavaToolchainImpl should b…
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #934:
URL: https://github.com/apache/maven/pull/934#issuecomment-1364179158
JIRA issue also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #934: [MNG-7352] org.apache.maven.toolchain.java.JavaToolchainImpl should b…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #934: [MNG-7352] org.apache.maven.toolchain.java.JavaToolchainImpl should b…
URL: https://github.com/apache/maven/pull/934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org