You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/21 14:15:00 UTC
[GitHub] [airflow] yuqian90 opened a new pull request #21018: Fix opening "Task Instance Details" page in web UI unintentionally resets TaskInstance.max_tries
yuqian90 opened a new pull request #21018:
URL: https://github.com/apache/airflow/pull/21018
closes: #21017
---
Do not change `max_tries` in `refresh_from_tasks()`. This is to prevent the web UI from accidentally resetting the value of `max_tries` to the initial value and causing tasks in "reschedule" mode to raise `AirflowSensorTimeout` prematurely.
Note that this PR only addresses the symptom reported in #21017. A more comprehensive fix should be to stop auto-committing the session in `views.py` in functions that are not supposed to modify the database. That can be done separately if someone is interested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21018: Fix opening "Task Instance Details" page in web UI unintentionally resets TaskInstance.max_tries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21018:
URL: https://github.com/apache/airflow/pull/21018#issuecomment-1019140371
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #21018: Fix opening "Task Instance Details" page in web UI unintentionally resets TaskInstance.max_tries
Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #21018:
URL: https://github.com/apache/airflow/pull/21018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org