You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/07/27 17:27:11 UTC
Review Request 61187: SENTRY-1868 SentryStore should set
loadResultsAtCommit to false when query result isn't needed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61187/
-----------------------------------------------------------
Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vadim Spector.
Bugs: SENTRY-1868
https://issues.apache.org/jira/browse/SENTRY-1868
Repository: sentry
Description
-------
SENTRY-1868 SentryStore should set loadResultsAtCommit to false when query result isn't needed
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 670bc5e29bed4f8f14b7f9a75a86934c6e4ac5b4
Diff: https://reviews.apache.org/r/61187/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 61187: SENTRY-1868 SentryStore should set
loadResultsAtCommit to false when query result isn't needed
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61187/#review181591
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 27, 2017, 5:27 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61187/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 5:27 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vadim Spector.
>
>
> Bugs: SENTRY-1868
> https://issues.apache.org/jira/browse/SENTRY-1868
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1868 SentryStore should set loadResultsAtCommit to false when query result isn't needed
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 670bc5e29bed4f8f14b7f9a75a86934c6e4ac5b4
>
>
> Diff: https://reviews.apache.org/r/61187/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 61187: SENTRY-1868 SentryStore should set
loadResultsAtCommit to false when query result isn't needed
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61187/#review181594
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 304 (patched)
<https://reviews.apache.org/r/61187/#comment257184>
the query should return results. why set this to false?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 318 (patched)
<https://reviews.apache.org/r/61187/#comment257185>
The query returns results. Why set this false?
- Na Li
On July 27, 2017, 5:27 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61187/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 5:27 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vadim Spector.
>
>
> Bugs: SENTRY-1868
> https://issues.apache.org/jira/browse/SENTRY-1868
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1868 SentryStore should set loadResultsAtCommit to false when query result isn't needed
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 670bc5e29bed4f8f14b7f9a75a86934c6e4ac5b4
>
>
> Diff: https://reviews.apache.org/r/61187/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>