You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/04 13:55:38 UTC

[GitHub] [openwhisk-wskdeploy] woutersterp opened a new pull request #1098: Add dotnet core 3.1 action support

woutersterp opened a new pull request #1098:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1098


   I think this is the only thing to be added for dotnet core 3.1 support right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1098: Add dotnet core 3.1 action support

Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1098:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1098#issuecomment-788540943


   @woutersterp Please rebase and add some "helloworld" style unit and integration tests (manifests) to verify support in our CI/CD process (Travis).  Please reference the work done for the updated Rust runtime in this PR to get an idea of what the balance of work is needed here: https://github.com/apache/openwhisk-wskdeploy/pull/1119


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1098: Add dotnet core 3.1 action support

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1098:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1098#issuecomment-788540943


   Please rebase and add some "helloworld" style unit and integration tests (manifests) to verify support in our CI/CD process (Travis).  Please reference the work done for the updated Rust runtime in this PR to get an idea of what the balance of work is needed here: https://github.com/apache/openwhisk-wskdeploy/pull/1119


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1098: Add dotnet core 3.1 action support

Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1098:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1098#discussion_r585214000



##########
File path: runtimes/runtimes.go
##########
@@ -480,6 +480,21 @@ var RUNTIME_DETAILS = []byte(`{
                     "attachmentName": "codefile",
                     "attachmentType": "text/plain"
                 }
+            },	    
+            {
+                "kind": "dotnet:3.1",

Review comment:
       Please add unit tests and perhaps an integration test to validate support in our CI/CD process. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org