[GitHub] markusthoemmes commented on a change in pull request #4234: Add limit to not store activations for a limitted namespace.

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4234: Add limit to not store activations for a limitted namespace.
URL: https://github.com/apache/incubator-openwhisk/pull/4234#discussion_r250142759
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/actions/PrimitiveActions.scala
 ##########
 @@ -569,7 +569,9 @@ protected[actions] trait PrimitiveActions {
       }
     }
 
-    activationStore.store(activation, context)(transid, notifier = None)
+    if (user.limits.storeActivations.getOrElse(true)) {
 
 Review comment:
   Can/should we move this into the ActivationStore itself? The user's identity is available in there as well.
   
   I guess the thought was to not do that, because then each store needs to make sure to implement this if? Can we instead maybe come up with a wrapper function for all `activationStore.store` calls that takes care of a general concern like this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services