[GitHub] guacamole-server pull request #165: GUACAMOLE-482: Allow encoding to proceed...

[mike-jumper <gi...@git.apache.org>]

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-server/pull/165

    GUACAMOLE-482: Allow encoding to proceed despite invalid instructions.

    guacenc should not fail the encoding process in cases where `Guacamole.Client` would not drop the connection, such as when a "blob" instruction is received for an unsupported stream.
    
    This difference in behavior is a regression introduced by commit 19b5050, and is causing encoding failures if a session recording contains data from an audio stream. Session recordings do not currently include the initial "audio" instruction beginning such streams, thus any related "blob" instructions always appear invalid to guacenc.
    
    This change logs instruction failures rather than aborting the entire encoding process.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-server guacenc-regression

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-server/pull/165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #165
    
----
commit 8d43c4344d8db0e92bd505882756288792248c8e
Author: Michael Jumper <mj...@...>
Date:   2018-04-12T22:07:45Z

    GUACAMOLE-482: Ignore invalid instructions within guacenc. Log failure at debug level.

----


---

[GitHub] guacamole-server pull request #165: GUACAMOLE-482: Allow encoding to proceed...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/guacamole-server/pull/165


---