You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2020/03/29 17:46:31 UTC
[GitHub] [incubator-annotator-website] Treora opened a new pull request #13:
Deduplicate demo code
Treora opened a new pull request #13: Deduplicate demo code
URL: https://github.com/apache/incubator-annotator-website/pull/13
Use git submodule to deduplicate demo code.
It seems more managable than duplicated code, but it is not yet ideal
either. Some subideal aspects:
The demo on the website currently has the header and footer of the main
page; this is now removed. Is that an issue?
It now puts the demo in `/content/demo`, but for this has to put `style.css`
into `/content/`. We could consider to instead put the whole `/web/dist`
from upstream into `/content/web` (or whatever name), but then the demo
URL will change to be `…/web/demo` (instead of just `…/demo`).
Files get removed, built and copied in a single line in package.json.
Better suggestions?
One needs to keep the submodule in sync; may be okay, updating the demo
is a manual process already anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator-website] BigBlueHat commented on issue #13:
Deduplicate demo code
Posted by GitBox <gi...@apache.org>.
BigBlueHat commented on issue #13: Deduplicate demo code
URL: https://github.com/apache/incubator-annotator-website/pull/13#issuecomment-606028743
...never liked the tangle of review + merge + close issue...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator-website] Treora opened a new pull request #13:
Deduplicate demo code
Posted by GitBox <gi...@apache.org>.
Treora opened a new pull request #13: Deduplicate demo code
URL: https://github.com/apache/incubator-annotator-website/pull/13
Use git submodule to deduplicate demo code.
It seems more managable than duplicated code, but it is not yet ideal
either. Some subideal aspects:
The demo on the website currently has the header and footer of the main
page; this is now removed. Is that an issue?
It now puts the demo in `/content/demo`, but for this has to put `style.css`
into `/content/`. We could consider to instead put the whole `/web/dist`
from upstream into `/content/web` (or whatever name), but then the demo
URL will change to be `…/web/demo` (instead of just `…/demo`).
Files get removed, built and copied in a single line in package.json.
Better suggestions?
One needs to keep the submodule in sync; may be okay, updating the demo
is a manual process already anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator-website] BigBlueHat closed pull request #13:
Deduplicate demo code
Posted by GitBox <gi...@apache.org>.
BigBlueHat closed pull request #13: Deduplicate demo code
URL: https://github.com/apache/incubator-annotator-website/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator-website] BigBlueHat merged pull request #13:
Deduplicate demo code
Posted by GitBox <gi...@apache.org>.
BigBlueHat merged pull request #13: Deduplicate demo code
URL: https://github.com/apache/incubator-annotator-website/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services