You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2015/05/01 18:14:22 UTC
[1/2] trafficserver git commit: TS-3539: close excess files in crash
log helper
Repository: trafficserver
Updated Branches:
refs/heads/master 523b47493 -> 4a4507216
TS-3539: close excess files in crash log helper
The crash log helper is spawned from traffic_server, so we should
close all the open files before exec'ing so that we don't leak
listen sockets or other resources into the child process.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a5c26250
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a5c26250
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a5c26250
Branch: refs/heads/master
Commit: a5c26250fc085c430dda7d0bd125cd671547a16e
Parents: 523b474
Author: James Peach <jp...@apache.org>
Authored: Tue Apr 28 15:54:51 2015 -0700
Committer: James Peach <jp...@apache.org>
Committed: Fri May 1 09:07:18 2015 -0700
----------------------------------------------------------------------
CHANGES | 4 ++++
proxy/Crash.cc | 8 ++++++++
2 files changed, 12 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a5c26250/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index d933cbb..be3ddcd 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,8 +1,12 @@
-*- coding: utf-8 -*-
Changes with Apache Traffic Server 6.0.0
+ *) [TS-3539] Close excess file descriptors in crash log helper.
+
*) [TS-3576] Remove the need for FIPS locking for OpenSSL
+ *) [TS-3538]: Perform server certificate validity check.
+
*) [TS-3575] Fix connection leak.
*) [TS-3538] Perform server certificate validity check.
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a5c26250/proxy/Crash.cc
----------------------------------------------------------------------
diff --git a/proxy/Crash.cc b/proxy/Crash.cc
index dbfe8fc..0febbea 100644
--- a/proxy/Crash.cc
+++ b/proxy/Crash.cc
@@ -111,6 +111,14 @@ crash_logger_init()
dup2(pipe[1], STDIN_FILENO);
close(pipe[0]);
close(pipe[1]);
+
+ // Starting after stderr, keep closing file descriptors until we run out.
+ for (int fd = STDERR_FILENO + 1; fd; ++fd) {
+ if (close(fd) == -1) {
+ break;
+ }
+ }
+
ink_release_assert(execl(logger, basename, "--syslog", "--wait", "--host", TS_BUILD_CANONICAL_HOST, NULL) != -1);
return; // not reached.
}
[2/2] trafficserver git commit: Fix CHANGES formatting
Posted by jp...@apache.org.
Fix CHANGES formatting
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/4a450721
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/4a450721
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/4a450721
Branch: refs/heads/master
Commit: 4a4507216354833ba39140a78d4cf10357f6e582
Parents: a5c2625
Author: James Peach <jp...@apache.org>
Authored: Fri May 1 09:08:02 2015 -0700
Committer: James Peach <jp...@apache.org>
Committed: Fri May 1 09:08:02 2015 -0700
----------------------------------------------------------------------
CHANGES | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/4a450721/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index be3ddcd..6c88873 100644
--- a/CHANGES
+++ b/CHANGES
@@ -5,13 +5,13 @@ Changes with Apache Traffic Server 6.0.0
*) [TS-3576] Remove the need for FIPS locking for OpenSSL
- *) [TS-3538]: Perform server certificate validity check.
+ *) [TS-3538] Perform server certificate validity check.
*) [TS-3575] Fix connection leak.
*) [TS-3538] Perform server certificate validity check.
- *) [TS-3549] Configurable option to avoid thundering herd problem
+ *) [TS-3549] Configurable option to avoid thundering herd problem
for multiple concurrent requests. The initial POC patch for this
solution came from Justin Laue. This patch will further be
improved with a few more changes to possibly support SWR feature in
@@ -122,7 +122,6 @@ Changes with Apache Traffic Server 6.0.0
*) [TS-3456] SSL blind tunnel sometimes not created.
-
Changes with Apache Traffic Server 5.3.0
*) [TS-3468] Make command 'check' work usefully.
@@ -409,7 +408,6 @@ Changes with Apache Traffic Server 5.3.0
*) [TS-1570] Remap doesn't reject request with extract characters after port
in Host header. Author: Cynthia Gu <cz...@linkedin.com>
-
Changes with Apache Traffic Server 5.2.0
*) [TS-3280] Segfault in new freelist bulk freeing (in debug mode).