You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/12/23 21:33:00 UTC
[jira] [Commented] (GEODE-7612) Move statistics and logging
implementation into .cpp files
[ https://issues.apache.org/jira/browse/GEODE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002494#comment-17002494 ]
ASF subversion and git services commented on GEODE-7612:
--------------------------------------------------------
Commit 154bbf17b6b94bdf012a3c06801015bd4d997601 in geode-native's branch refs/heads/develop from Matthew Reddington
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=154bbf1 ]
GEODE-7612: Technical debt 01 - remove inlining in logging and statistics classes (#563)
* Moved some implementation from headers into source files. Replaced some usage of NonCopyable and NonAssignable. Also, in C++ 11 you are explicitly allowed to default a virtual destructor.
* Changed some implementation in Log::enabled and Log::debugEnabled on account of Apple - sins hidden by inline complicating matters.
> Move statistics and logging implementation into .cpp files
> ----------------------------------------------------------
>
> Key: GEODE-7612
> URL: https://issues.apache.org/jira/browse/GEODE-7612
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As a developer, I would like to minimize the time spent recompiling code that I haven't modified. One important way to improve this situation in the native client is to move some of the bazillions of inline methods declared in headers into .cpp files. A change to one of these methods then triggers a recompile of just that file, rather than the large number of native client files that inevitably include the header.
> This item covers the above transformation for the internal classes involved in logging and statistics. While there, we should clean up a couple of other things that are unnecessary, such as the use of our own `NonCopyable` and `NonAssignable`, both of which can now easily be accomplished with a standard C++ 11 mechanism.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)