You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Gregory Maes (JIRA)" <ji...@apache.org> on 2007/03/06 16:03:24 UTC
[jira] Created: (WICKET-364) Use an uniform behavior for the
expiration page
Use an uniform behavior for the expiration page
-----------------------------------------------
Key: WICKET-364
URL: https://issues.apache.org/jira/browse/WICKET-364
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3
Reporter: Gregory Maes
Fix For: 1.3
The expiration page does not behave the same according to whether we are in ajax mode or not.
In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-364) Use an uniform behavior for the
expiration page
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479265 ]
Jean-Baptiste Quenot commented on WICKET-364:
---------------------------------------------
As long as trunk is alive, no.
> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
> Key: WICKET-364
> URL: https://issues.apache.org/jira/browse/WICKET-364
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Gregory Maes
> Assigned To: Jean-Baptiste Quenot
> Fix For: 1.3
>
> Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not.
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-364) Use an uniform behavior for the
expiration page
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot resolved WICKET-364.
-----------------------------------------
Resolution: Fixed
Won't fix this in trunk.
> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
> Key: WICKET-364
> URL: https://issues.apache.org/jira/browse/WICKET-364
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Gregory Maes
> Assigned To: Jean-Baptiste Quenot
> Fix For: 1.3
>
> Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not.
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-364) Use an uniform behavior for the
expiration page
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478831 ]
Jean-Baptiste Quenot commented on WICKET-364:
---------------------------------------------
Fixed in 1.x, thanks for your patch!
> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
> Key: WICKET-364
> URL: https://issues.apache.org/jira/browse/WICKET-364
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Gregory Maes
> Assigned To: Jean-Baptiste Quenot
> Fix For: 1.3
>
> Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not.
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-364) Use an uniform behavior for the
expiration page
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478961 ]
Alastair Maw commented on WICKET-364:
-------------------------------------
Should this be marked as closed?
> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
> Key: WICKET-364
> URL: https://issues.apache.org/jira/browse/WICKET-364
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Gregory Maes
> Assigned To: Jean-Baptiste Quenot
> Fix For: 1.3
>
> Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not.
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-364) Use an uniform behavior for the
expiration page
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-364:
----------------------------------------
Fix Version/s: (was: trunk)
1.3.0-beta1
> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
> Key: WICKET-364
> URL: https://issues.apache.org/jira/browse/WICKET-364
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Gregory Maes
> Assignee: Jean-Baptiste Quenot
> Fix For: 1.3.0-beta1
>
> Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not.
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-364) Use an uniform behavior for the
expiration page
Posted by "Gregory Maes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Maes updated WICKET-364:
--------------------------------
Attachment: wicket-364.patch
> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
> Key: WICKET-364
> URL: https://issues.apache.org/jira/browse/WICKET-364
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Gregory Maes
> Fix For: 1.3
>
> Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not.
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-364) Use an uniform behavior for the
expiration page
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot reassigned WICKET-364:
-------------------------------------------
Assignee: Jean-Baptiste Quenot
> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
> Key: WICKET-364
> URL: https://issues.apache.org/jira/browse/WICKET-364
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Gregory Maes
> Assigned To: Jean-Baptiste Quenot
> Fix For: 1.3
>
> Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not.
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor would respond with a redirection to the expired page in both case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.