You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 20:55:57 UTC

[GitHub] [flink] kl0u commented on pull request #12233: [FLINK-17745] Remove nested jar handling from PackagedProgram

kl0u commented on pull request #12233:
URL: https://github.com/apache/flink/pull/12233#issuecomment-630430453


   You are right @zentol that the nested jars will not be accessible by default. My main point about the "redundant" part is that we ship them twice, once as part of the original jar and once as the extracted libs.
   
   The reason for removing this part is that it seems pretty counterintuitive, as it requires to put the dependencies in a `lib/` folder (from what I understand from the code). I am not even sure if this way of submission is even documented anywhere. In addition, we already have options that allow for shipping additional files apart from the main jar and adding them to the classpath.
   
   Do you have any objections about removing this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org