You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/17 20:24:16 UTC
[GitHub] [superset] codemaster08240328 opened a new pull request #18796: fix: Monospacing errors in dashboards & charts
codemaster08240328 opened a new pull request #18796:
URL: https://github.com/apache/superset/pull/18796
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
On Charts and Dashboards, if the user has an error, the error message should be displayed in a monospace font so some of the formatting / details is not lost.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
> Before
> After
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #18796:
URL: https://github.com/apache/superset/pull/18796#discussion_r810814255
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -113,6 +113,14 @@ const RefreshOverlayWrapper = styled.div`
justify-content: center;
`;
+const MonospaceDiv = styled.div`
Review comment:
nit: I would perhaps consider naming this `MonospaceMessage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043532768
@rusackas Ephemeral environment spinning up at http://54.185.22.55:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043621687
This has a side effect of monospacing ANY error in this dashboard/explore context. See screenshot below of one example.
<img width="1290" alt="image" src="https://user-images.githubusercontent.com/812905/154589033-c8c90d4a-9e4f-4be0-a99e-28274ed0884a.png">
@kasiazjc any objections to this? I think the pros outweigh the cons here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] removed a comment on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043466651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #18796:
URL: https://github.com/apache/superset/pull/18796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043530594
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas removed a comment on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
rusackas removed a comment on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043466136
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1050561445
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043466136
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043529708
# [Codecov](https://codecov.io/gh/apache/superset/pull/18796?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18796](https://codecov.io/gh/apache/superset/pull/18796?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (683c265) into [master](https://codecov.io/gh/apache/superset/commit/2d67d2f14e8143e2e1589d2e3cd9218fb06562ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d67d2f) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 683c265 differs from pull request most recent head 93b3f7d. Consider uploading reports for the commit 93b3f7d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18796 +/- ##
=======================================
Coverage 66.32% 66.32%
=======================================
Files 1620 1620
Lines 63087 63089 +2
Branches 6372 6372
=======================================
+ Hits 41840 41842 +2
Misses 19590 19590
Partials 1657 1657
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.26% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18796?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/18796/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `53.44% <100.00%> (+1.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18796?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18796?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2d67d2f...93b3f7d](https://codecov.io/gh/apache/superset/pull/18796?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1043466637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #18796: fix: Monospacing errors in dashboards & charts
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on pull request #18796:
URL: https://github.com/apache/superset/pull/18796#issuecomment-1044452841
@rusackas does error always contain sql/code? If yes, I think that pros outweigh the cons if we cannot separate those. If no - this could create more confusion 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org