[GitHub] [helix] narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #765: Add DedicatedZkClient and update DedicatedZkClientFactory
URL: https://github.com/apache/helix/pull/765#discussion_r380862050
 
 

 ##########
 File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/SharedZkClientFactory.java
 ##########
 @@ -44,15 +44,17 @@ protected SharedZkClientFactory() {
   @Override
   public RealmAwareZkClient buildZkClient(
       RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
-      RealmAwareZkClient.RealmAwareZkClientConfig clientConfig) {
+      RealmAwareZkClient.RealmAwareZkClientConfig clientConfig,
 
 Review comment:
   There was a change in the interface. SharedZkClient implements that interface. So this change is just a signature change, not logical change. 
   
   This change is necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org