[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

["Lars Hofhansl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484697#comment-13484697 ] 

Lars Hofhansl commented on HBASE-6563:
--------------------------------------

I'm not a fan of catching NPE. They should be addressed by null checks.
Also, I see in Store.isMajorCompaction (in 0.94+) that there already is such a null check.
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.3
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira