[jira] [Commented] (CALCITE-3887) Filter and Join conditions may not need to retain nullability during simplifications

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071173#comment-17071173 ] 

Julian Hyde commented on CALCITE-3887:
--------------------------------------

{{RelBuilder.join}} and {{RelBuilder.filter}} use a different path ({{RexSimplifier.simplifyUnknownAsFalse}}) but can you make sure that they don't make the same mistake. Add {{RelBuilderTest}} tests if necessary.

As I remarked on the mailing list, {{IS TRUE}} and {{IS NOT FALSE}} are very similar to nullability casts. Adding or removing them do not affect the result of predicates used in join or filter. Do you think we should simplify by removing them?

> Filter and Join conditions may not need to retain nullability during simplifications
> ------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3887
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3887
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Reported by [~icshuo]: that there are situation in which join conditions are placed inside a redundant `CAST`.
> https://mail-archives.apache.org/mod_mbox/calcite-dev/202003.mbox/%3CCABYySnvtrMFWaBqM7_FgKedXELdXeCqciRJV7G4MyYN07HUOnQ%40mail.gmail.com%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)