[GitHub] [httpcomponents-core] LaunchPairs commented on issue #152: validate connections everytime

[GitBox <gi...@apache.org>]

LaunchPairs commented on issue #152: validate connections everytime
URL: https://github.com/apache/httpcomponents-core/pull/152#issuecomment-535870956
 
 
   > @hokuda I need to understand what it is exactly you are trying to accomplish before we make any API visible changes or break compatibility.
   > Why can't you just use 1 ms instead of 0 ms? It is as _almost_ as likely that a connection can go stale immediately after passing the validation with 1 ms or 0 ms setting
   
   On our performance test environment, we still see a lot of cases with 1ms where the httpclient uses a stale TCP connection. If we use a version that always validates the connection, we haven't seen a single case yet. With this manually changed version, we completely ignore with the two checks:
   
   `                    } else if (this.validateAfterInactivity > 0) { 
                           if (entry.getUpdated() + this.validateAfterInactivity <= System.currentTimeMillis())  {`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org