[jira] [Commented] (MESOS-5937) `flags::parse` assumes the filesystem is rooted at '/'

["Jeff Coffler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959837#comment-15959837 ] 

Jeff Coffler commented on MESOS-5937:
-------------------------------------

Create new O/S function (os::) to determine absolute path, implement it in this test.

3rdparty\stout\include\stout\windows\os.hpp
3rdparty\stout\include\stout\posix\os.hpp

Check if there is an absolute path function already.

> `flags::parse` assumes the filesystem is rooted at '/'
> ------------------------------------------------------
>
>                 Key: MESOS-5937
>                 URL: https://issues.apache.org/jira/browse/MESOS-5937
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: Alex Clemmer
>            Assignee: Alex Clemmer
>              Labels: mesosphere, microsoft, stout, windows
>
> This bug causes the following tests to fail:
> * FlagsFileTest.JSONFile
> In parse.hpp, in the `flags::parse` contains a line like:
> ```
> if (strings::startsWith(value, "/")) {
> ```
> Normally to load a JSON flags file, we will specify a file like: `file://file_here`. This line exists for backwards compatibility. But since it's FS-specific, this will fail on Windows.
> As of this writing, this causes `FlagsFileTest.JSONFile` to fail.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)