You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/22 10:41:31 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #11736: Vault with optional Variables

kaxil commented on a change in pull request #11736:
URL: https://github.com/apache/airflow/pull/11736#discussion_r510060302



##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -112,7 +112,7 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin):
     def __init__(  # pylint: disable=too-many-arguments
         self,
         connections_path: str = 'connections',
-        variables_path: str = 'variables',
+        variables_path: Optional[str] = None,

Review comment:
       @fhoda By default if Variables are not found in Vault, it will fallback to your Environment variable and then DB.
   
   Is thing change intended to reduce the API call or any other reason? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org