You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/16 05:41:09 UTC
[GitHub] john-bodley commented on a change in pull request #5216: [sqllab]
Fix sql lab resolution link
john-bodley commented on a change in pull request #5216: [sqllab] Fix sql lab resolution link
URL: https://github.com/apache/incubator-superset/pull/5216#discussion_r195895037
##########
File path: superset/assets/src/SqlLab/actions.js
##########
@@ -114,7 +114,11 @@ export function fetchQueryResults(query) {
if (err.responseJSON && err.responseJSON.error) {
msg = err.responseJSON.error;
}
- dispatch(queryFailed(query, msg));
+ let link = '';
Review comment:
Can this logic be added to queryFailed so it’s not repeated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org