You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/09/06 16:50:55 UTC

[GitHub] [airflow] eumiro commented on pull request #34111: Refactor: Consolidate "import numpy as np"

eumiro commented on PR #34111:
URL: https://github.com/apache/airflow/pull/34111#issuecomment-1708759478

   > I don’t really have issues either way, but why do we consolidate to `datetime` instead of `dt` but `np` instead of `numpy`? It seems slightly inconsistent.
   
   `import numpy as np` appears already on their website and is widely accepted in the community.
   
   I have no strong opinion on importing `datetime`, but `dt` appears already quite often as a variable name and with airflow's version of `datetime`, we have a consistency issue with it. I'd be happy to discuss importing of `datetime`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org