You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/02/11 15:59:27 UTC
Review Request 30879: Ambari HDFS jmx give none/wrong status in https
setup for hdfs and yarn, etc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/
-----------------------------------------------------------
Review request for Ambari and John Speidel.
Bugs: AMBARI-9566
https://issues.apache.org/jira/browse/AMBARI-9566
Repository: ambari
Description
-------
PROBLEM:
HDP 2.2.0, Ambari 1.7.0.
When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
required ssl-server.xml and ssl-client.xml, hdfs function fine.
But Ambari UI shows no metrics for namenode, even shows 'upgrade not
finalized' when it is a fresh HDP 2.2.0. install.
A few notes:
1\. there is no option in 'ambari-server setup-security' or documentation on
how to set up trust store for Ambari to trust hdfs/yarn
2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
https is enabled. This is deprecated since hdp 2.1. The property should be
dfs.http.policy, yarn.http.policy.
screenshot attached that shows the wrong and missing metrics, and screenshot
of the jmx from namenode
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
ambari-web/app/models/service_config.js 999d1b5
Diff: https://reviews.apache.org/r/30879/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72213
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Feb. 12, 2015, 7:06 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 7:06 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9566
> https://issues.apache.org/jira/browse/AMBARI-9566
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> HDP 2.2.0, Ambari 1.7.0.
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
>
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
>
> A few notes:
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
>
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
>
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java d8e478a
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
> ambari-web/app/models/service_config.js 999d1b5
>
> Diff: https://reviews.apache.org/r/30879/diff/
>
>
> Testing
> -------
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 41 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [8.873s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.365s]
> [INFO] Ambari Web ........................................ SUCCESS [1:01.055s]
> [INFO] Ambari Views ...................................... SUCCESS [5.658s]
> [INFO] Ambari Admin View ................................. SUCCESS [25.783s]
> [INFO] Ambari Server ..................................... SUCCESS [33:27.424s]
> [INFO] Ambari Agent ...................................... SUCCESS [11.128s]
> [INFO] Ambari Client ..................................... SUCCESS [0.063s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.372s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.368s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.066s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.093s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [8.573s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:41.785s
> [INFO] Finished at: Thu Feb 12 21:01:52 EET 2015
> [INFO] Final Memory: 61M/544M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 7:06 p.m.)
Review request for Ambari and John Speidel.
Bugs: AMBARI-9566
https://issues.apache.org/jira/browse/AMBARI-9566
Repository: ambari
Description
-------
PROBLEM:
HDP 2.2.0, Ambari 1.7.0.
When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
required ssl-server.xml and ssl-client.xml, hdfs function fine.
But Ambari UI shows no metrics for namenode, even shows 'upgrade not
finalized' when it is a fresh HDP 2.2.0. install.
A few notes:
1\. there is no option in 'ambari-server setup-security' or documentation on
how to set up trust store for Ambari to trust hdfs/yarn
2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
https is enabled. This is deprecated since hdp 2.1. The property should be
dfs.http.policy, yarn.http.policy.
screenshot attached that shows the wrong and missing metrics, and screenshot
of the jmx from namenode
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java d8e478a
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
ambari-web/app/models/service_config.js 999d1b5
Diff: https://reviews.apache.org/r/30879/diff/
Testing (updated)
-------
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 41 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [8.873s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.365s]
[INFO] Ambari Web ........................................ SUCCESS [1:01.055s]
[INFO] Ambari Views ...................................... SUCCESS [5.658s]
[INFO] Ambari Admin View ................................. SUCCESS [25.783s]
[INFO] Ambari Server ..................................... SUCCESS [33:27.424s]
[INFO] Ambari Agent ...................................... SUCCESS [11.128s]
[INFO] Ambari Client ..................................... SUCCESS [0.063s]
[INFO] Ambari Python Client .............................. SUCCESS [0.372s]
[INFO] Ambari Groovy Client .............................. SUCCESS [11.368s]
[INFO] Ambari Shell ...................................... SUCCESS [0.066s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.093s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [8.573s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 35:41.785s
[INFO] Finished at: Thu Feb 12 21:01:52 EET 2015
[INFO] Final Memory: 61M/544M
[INFO] -----------------------------------------------------------------------
Thanks,
Andrew Onischuk
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Feb. 12, 2015, 6:24 p.m., John Speidel wrote:
> > Latest patch looks good. Please provide the unit test output from 'mvn clean test' and describe the manual functional tests that you have run.
Manual steps:
1. Create HTTPS certificates and keystore/truststore files
2. Set the following properties in core-site.xml:
-------
hadoop.ssl.require.client.cert=false
hadoop.ssl.hostname.verifier=DEFAULT
hadoop.ssl.keystores.factory.class=org.apache.hadoop.security.ssl.FileBasedKeyStoresFactory
hadoop.ssl.server.conf=ssl-server.xml
hadoop.ssl.client.conf=ssl-client.xml
-------
3. Add ssl-server.xml and ssl-client.xml to /etc/hadoop/conf directory.
4. Add ssl properties If they are missed in ambari.properties file:
-------
ssl.trustStore.path=path_to_trustStore_file
ssl.trustStore.password=password
ssl.trustStore.type=truestore_type
-------
5. Change hdfs.http.policy value in hdfs-site.xml to "HTTPS_ONLY"
6. Add yarn.http.policy value in yarn-site.xml to "HTTPS_ONLY"
7. Restart services.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72207
-----------------------------------------------------------
On Feb. 12, 2015, 7:06 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 7:06 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9566
> https://issues.apache.org/jira/browse/AMBARI-9566
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> HDP 2.2.0, Ambari 1.7.0.
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
>
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
>
> A few notes:
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
>
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
>
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java d8e478a
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
> ambari-web/app/models/service_config.js 999d1b5
>
> Diff: https://reviews.apache.org/r/30879/diff/
>
>
> Testing
> -------
>
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 41 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [8.873s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.365s]
> [INFO] Ambari Web ........................................ SUCCESS [1:01.055s]
> [INFO] Ambari Views ...................................... SUCCESS [5.658s]
> [INFO] Ambari Admin View ................................. SUCCESS [25.783s]
> [INFO] Ambari Server ..................................... SUCCESS [33:27.424s]
> [INFO] Ambari Agent ...................................... SUCCESS [11.128s]
> [INFO] Ambari Client ..................................... SUCCESS [0.063s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.372s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [11.368s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.066s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.093s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [8.573s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 35:41.785s
> [INFO] Finished at: Thu Feb 12 21:01:52 EET 2015
> [INFO] Final Memory: 61M/544M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72207
-----------------------------------------------------------
Ship it!
Latest patch looks good. Please provide the unit test output from 'mvn clean test' and describe the manual functional tests that you have run.
- John Speidel
On Feb. 12, 2015, 5:09 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 5:09 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9566
> https://issues.apache.org/jira/browse/AMBARI-9566
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> HDP 2.2.0, Ambari 1.7.0.
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
>
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
>
> A few notes:
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
>
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
>
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java d8e478a
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
> ambari-web/app/models/service_config.js 999d1b5
>
> Diff: https://reviews.apache.org/r/30879/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 5:09 p.m.)
Review request for Ambari and John Speidel.
Bugs: AMBARI-9566
https://issues.apache.org/jira/browse/AMBARI-9566
Repository: ambari
Description
-------
PROBLEM:
HDP 2.2.0, Ambari 1.7.0.
When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
required ssl-server.xml and ssl-client.xml, hdfs function fine.
But Ambari UI shows no metrics for namenode, even shows 'upgrade not
finalized' when it is a fresh HDP 2.2.0. install.
A few notes:
1\. there is no option in 'ambari-server setup-security' or documentation on
how to set up trust store for Ambari to trust hdfs/yarn
2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
https is enabled. This is deprecated since hdp 2.1. The property should be
dfs.http.policy, yarn.http.policy.
screenshot attached that shows the wrong and missing metrics, and screenshot
of the jmx from namenode
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java d8e478a
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
ambari-web/app/models/service_config.js 999d1b5
Diff: https://reviews.apache.org/r/30879/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72184
-----------------------------------------------------------
Ship it!
forgot to select the "Ship It" box
- John Speidel
On Feb. 11, 2015, 2:59 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 2:59 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9566
> https://issues.apache.org/jira/browse/AMBARI-9566
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> HDP 2.2.0, Ambari 1.7.0.
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
>
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
>
> A few notes:
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
>
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
>
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
> ambari-web/app/models/service_config.js 999d1b5
>
> Diff: https://reviews.apache.org/r/30879/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by John Speidel <js...@hortonworks.com>.
> On Feb. 12, 2015, 4:08 p.m., Tom Beerbower wrote:
> > Looks good.
> >
> > Is there unit test coverage for the new code where httpsEnabled == true?
+1 for a unit test(s) for this prior to merging
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72180
-----------------------------------------------------------
On Feb. 11, 2015, 2:59 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 2:59 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9566
> https://issues.apache.org/jira/browse/AMBARI-9566
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> HDP 2.2.0, Ambari 1.7.0.
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
>
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
>
> A few notes:
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
>
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
>
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
> ambari-web/app/models/service_config.js 999d1b5
>
> Diff: https://reviews.apache.org/r/30879/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72180
-----------------------------------------------------------
Looks good.
Is there unit test coverage for the new code where httpsEnabled == true?
- Tom Beerbower
On Feb. 11, 2015, 2:59 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 2:59 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9566
> https://issues.apache.org/jira/browse/AMBARI-9566
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> HDP 2.2.0, Ambari 1.7.0.
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
>
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
>
> A few notes:
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
>
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
>
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
> ambari-web/app/models/service_config.js 999d1b5
>
> Diff: https://reviews.apache.org/r/30879/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 30879: Ambari HDFS jmx give none/wrong status in
https setup for hdfs and yarn, etc
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30879/#review72182
-----------------------------------------------------------
I would like to see a new unit test(s) added that excercises this issue before you merge.
Also, please include the output that shows that the unit tests were successful.
You didn't mention whether you did manual functional testing of this patch.
My +1 assumes that you did, if not please do so.
Looks generally good to me but I don't know this code very well so please wait for Tom Beerbower's review.
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java
<https://reviews.apache.org/r/30879/#comment118186>
curious why you are not using a primitive boolean here
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
<https://reviews.apache.org/r/30879/#comment118187>
curious why you are not using a primitive boolean here
- John Speidel
On Feb. 11, 2015, 2:59 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30879/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 2:59 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9566
> https://issues.apache.org/jira/browse/AMBARI-9566
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM:
>
> HDP 2.2.0, Ambari 1.7.0.
> When enable namnode HA with https by dfs.http.policy=HTTPS_ONLY, and set up
> required ssl-server.xml and ssl-client.xml, hdfs function fine.
>
> But Ambari UI shows no metrics for namenode, even shows 'upgrade not
> finalized' when it is a fresh HDP 2.2.0. install.
>
> A few notes:
> 1\. there is no option in 'ambari-server setup-security' or documentation on
> how to set up trust store for Ambari to trust hdfs/yarn
>
> 2\. it looks like Ambari still uses hadoop.ssl.enabled as criteria whether
> https is enabled. This is deprecated since hdp 2.1. The property should be
> dfs.http.policy, yarn.http.policy.
>
> screenshot attached that shows the wrong and missing metrics, and screenshot
> of the jmx from namenode
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 4c47a1c
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java 65f7be7
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java bbacb0d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml 6572935
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 69fb5f5
> ambari-web/app/models/service_config.js 999d1b5
>
> Diff: https://reviews.apache.org/r/30879/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>