You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2023/10/31 21:17:14 UTC

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

gsingh@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20639


Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................

IMPALA-12470: Support different schemes for jdbc driver url when
creating external jdbc table

This patch builds on top of IMPALA-5741 to copy the jdbc jar from
remote filesystems: Ozone and S3. Currenty we only support hdfs.

Testing:
Commented out "@skipif.not_hdfs" qualifier in files:
  - tests/query_test/test_ext_data_sources.py
  - tests/custom_cluster/test_ext_data_sources.py
1) tested locally by running tests:
  - impala-py.test tests/query_test/test_ext_data_sources.py
  - impala-py.test tests/custom_cluster/test_ext_data_sources.py
2) tested using jenkins job for ozone and S3

Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java
M testdata/bin/create-load-data.sh
M tests/custom_cluster/test_ext_data_sources.py
M tests/query_test/test_ext_data_sources.py
6 files changed, 65 insertions(+), 29 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/20639/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................

IMPALA-12470: Support different schemes for jdbc driver url when
creating external jdbc table

This patch builds on top of IMPALA-5741 to copy the jdbc jar from
remote filesystems: Ozone and S3. Currenty we only support hdfs.

Testing:
Commented out "@skipif.not_hdfs" qualifier in files:
  - tests/query_test/test_ext_data_sources.py
  - tests/custom_cluster/test_ext_data_sources.py
1) tested locally by running tests:
  - impala-py.test tests/query_test/test_ext_data_sources.py
  - impala-py.test tests/custom_cluster/test_ext_data_sources.py
2) tested using jenkins job for ozone and S3

Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Reviewed-on: http://gerrit.cloudera.org:8080/20639
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Wenzhe Zhou <wz...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java
M testdata/bin/create-load-data.sh
M tests/custom_cluster/test_ext_data_sources.py
M tests/query_test/test_ext_data_sources.py
6 files changed, 64 insertions(+), 29 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14297/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 18:28:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@52
PS1, Line 52: import java.io.File;
nit: don't need.


http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java:

http://gerrit.cloudera.org:8080/#/c/20639/1/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@191
PS1, Line 191: Path localJarPath = new Path(localPath);
             :       // Delete the jar file once its loaded
             :       FileSystemUtil.deleteIfExists(localJarPath);
To be safe, delete the local jar file in ExternalDataSourceExecutor.release() function https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/extdatasource/ExternalDataSourceExecutor.java#L189


http://gerrit.cloudera.org:8080/#/c/20639/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java
File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java:

http://gerrit.cloudera.org:8080/#/c/20639/1/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@20
PS1, Line 20: import java.io.IOException;
nit: keep alphabet order, move this line after line #21



-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Oct 2023 21:30:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has removed a vote on this change.

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
gsingh@cloudera.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................

IMPALA-12470: Support different schemes for jdbc driver url when
creating external jdbc table

This patch builds on top of IMPALA-5741 to copy the jdbc jar from
remote filesystems: Ozone and S3. Currenty we only support hdfs.

Testing:
Commented out "@skipif.not_hdfs" qualifier in files:
  - tests/query_test/test_ext_data_sources.py
  - tests/custom_cluster/test_ext_data_sources.py
1) tested locally by running tests:
  - impala-py.test tests/query_test/test_ext_data_sources.py
  - impala-py.test tests/custom_cluster/test_ext_data_sources.py
2) tested using jenkins job for ozone and S3

Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java
M testdata/bin/create-load-data.sh
M tests/custom_cluster/test_ext_data_sources.py
M tests/query_test/test_ext_data_sources.py
6 files changed, 64 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/20639/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14289/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Oct 2023 21:45:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 3: Code-Review+1

Changes looks good to me. I started GVO for this patch.
Please rerun tests on Jenkins with target file system as s3 and Ozone.


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 19:11:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 3: Code-Review+2

tests for patch set 3 on Jenkins with target file system as s3 and ozone were finished successfully.


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:10:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9866/


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:30:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9866/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 19:08:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 3:

One test failure caused by IMPALA-12528.


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:32:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20639 )

Change subject: IMPALA-12470: Support different schemes for jdbc driver url when creating external jdbc table
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I804fa3d239a4bedcd31569f2b46edb7316d7f004
Gerrit-Change-Number: 20639
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:32:08 +0000
Gerrit-HasComments: No