You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/22 01:45:46 UTC
[jira] [Commented] (TINKERPOP-983) Provide a way to track open
Graph instances in tests
[ https://issues.apache.org/jira/browse/TINKERPOP-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067348#comment-15067348 ]
ASF GitHub Bot commented on TINKERPOP-983:
------------------------------------------
GitHub user n-tran opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/184
TINKERPOP-983 - Provide a way to track open Graph instances in tests
Doing a test PR to see if Travis will build, there might be something wrong with my local environment. If Travis doesn't pass, I will rescind my PR.
Refactor tests to use member variables for `graphProvider`
Added Java docs
https://issues.apache.org/jira/browse/TINKERPOP-983
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP-983
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 0926604ecdfcf5c9ece592f94470df7d3434c701
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-12-02T00:18:42Z
Refactor tests to use member variables for graphProvider
commit 947d192e682fb1a3c9470c87bed8b4cebf69a60e
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-12-06T22:25:34Z
Initial development to track open graph instances in the tests.
Neo4j is currently not passing
commit 2c07233e98561a9609ea17ea7a24cf49fc6261fe
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-12-22T00:27:57Z
Added Java docs.
----
> Provide a way to track open Graph instances in tests
> ----------------------------------------------------
>
> Key: TINKERPOP-983
> URL: https://issues.apache.org/jira/browse/TINKERPOP-983
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Tests open {{Graph}} instances and if they fail to close them all (tends to happen on tests that throw exceptions and don't directly call {{close()}}), it can result in problems for providers when they run the tests. Provide a method to give the test writer feedback on {{Graph}} instances that aren't closed so that they know at test writing time of the problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)