[GitHub] [beam] boyuanzz commented on a change in pull request #15090: [BEAM-12008] Add New Coder for KafkaIO.Read() to Deal with Null Key

[GitBox <gi...@apache.org>]

boyuanzz commented on a change in pull request #15090:
URL: https://github.com/apache/beam/pull/15090#discussion_r665658872



##########
File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -838,6 +850,16 @@ public void setTimestampPolicy(String timestampPolicy) {
       }
     }
 
+    /**
+     * Sets nullKeyFlag for present of null keys
+     *
+     * <p>By default, nullKeyFlag is {@code false} and will invoke {@link KafkaRecordCoder} when
+     * nullKeyFlag is {@code true}, it invokes {@link NullableKeyKafkaRecordCoder}
+     */
+    public Read<K, V> withNullKeyFlag() {

Review comment:
       I think the major pushback for making this as a default one is update safe and backward compatibility. Let's say that we make this by default from beam 2.33.0. Then customers with pipeline prior to 2.33.0 will not be able to update their streaming pipeline to 2.33.0 because of coder incompatibility. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org