[GitHub] [shardingsphere] totalo commented on a change in pull request #10840: Improve the initialization of OptimizeContextFactory for issue#10678

[GitBox <gi...@apache.org>]

totalo commented on a change in pull request #10840:
URL: https://github.com/apache/shardingsphere/pull/10840#discussion_r655090687



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/SchemaBuilder.java
##########
@@ -64,42 +63,61 @@
     static {
         ShardingSphereServiceLoader.register(DialectTableMetaDataLoader.class);
     }
-    
+
     /**
-     * Build ShardingSphere schema.
-     * 
+     * build actual and logic table meta data.
+     *
      * @param materials schema builder materials
-     * @return ShardingSphere schema
+     * @return actual and logic table meta data
      * @throws SQLException SQL exception
      */
-    public static ShardingSphereSchema build(final SchemaBuilderMaterials materials) throws SQLException {
-        ShardingSphereSchema result = new ShardingSphereSchema();
-        addRuleConfiguredTables(materials, result);
-        appendRemainTables(materials, result);
+    public static Map<Map<String, TableMetaData>, Map<String, TableMetaData>> build(final SchemaBuilderMaterials materials) throws SQLException {

Review comment:
       Yes, I think that makes more sense, but I've noticed that a lot of places use maps, so I've gone that route. If adding a TableName property is a bit too much to change, can I fix it in the next PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org