You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "code4wt (GitHub)" <gi...@apache.org> on 2019/01/02 09:30:59 UTC

[GitHub] [incubator-dubbo] code4wt commented on pull request #3108: Replace hard coded dubbo-config-api values and small code optimization

Hi, this code style looks a bit strange, I suggest writing the comma after the variable, like this:

```java
throw new IllegalStateException(String.format("Unsupported environment: %s, only support %s/%s/%s, default is %s.",
        environment,
        EnvironmentConstants.DEVELOPMENT_ENVIRONMENT,
        EnvironmentConstants.TEST_ENVIRONMENT,
        EnvironmentConstants.PRODUCTION_ENVIRONMENT,
        EnvironmentConstants.PRODUCTION_ENVIRONMENT));
```

What do you think?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3108 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org