You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/12/14 19:29:13 UTC
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12092
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Symbolize stacktraces in debug builds.
It's convenient to have symbols if debugging debug builds.
Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
---
M be/src/common/init.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12092/1
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3570/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 22:54:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3573/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 Dec 2018 04:46:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 22:54:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 Dec 2018 08:35:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 19:42:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Symbolize stacktraces in debug builds.
It's convenient to have symbols if debugging debug builds.
Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Reviewed-on: http://gerrit.cloudera.org:8080/12092
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/init.cc
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 2:
Failure seemed to look flaky to me; retrying before digging in deeper.
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/3887/testReport/junit/failure.test_failpoints/TestFailpoints/test_lifecycle_failures/
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 Dec 2018 04:46:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3570/
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 Dec 2018 02:51:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 Dec 2018 04:46:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Symbolize stacktraces in debug builds.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12092 )
Change subject: Symbolize stacktraces in debug builds.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1610/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cc69829e155a56b59b9e5a821c2af83618bb40
Gerrit-Change-Number: 12092
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 20:01:00 +0000
Gerrit-HasComments: No