[GitHub] [incubator-superset] nladuguie opened a new issue #7170: Password not replaced in SQLAlchemy URL when impersonation is enabled causing 401 Unauthorized

[GitBox <gi...@apache.org>]

nladuguie opened a new issue #7170: Password not replaced in SQLAlchemy URL when impersonation is enabled causing 401 Unauthorized
URL: https://github.com/apache/incubator-superset/issues/7170
 
 
   Hi everybody, we use Superset to execute queries on a PrestoDB cluster.
   We activated the impersonation feature on our PrestoDB connection, because we want to identify which user run which query just for auditing.
   But when this feature is activated, all queries run result in a HTTP `401` error.
   FYI, we have securized our PrestoDB cluster with SSL access and LDAP authentifcation, so PrestoDB URL configured in Superset includes basic authentication with `user:password` inside it (see attached image).
   ![superset-presto-datasource](https://user-images.githubusercontent.com/19774518/55222504-5e7f5880-520c-11e9-8866-d900f0480779.PNG)
   
   This error appears right after saving the Presto datasource with those configurations.
   After debugging Superset execution, I observed that the impersonation features only replaces the username inside URL but not the password.
   So in the resulting impersonated URL, the current user name is associated with the configured password in the datasource, which is not correct.
   
   ### Superset version
   0.28.1
   
   ### Expected results
   Run query with impersonation feature enabled should replace password (is specified) in the datasource URL, like username is.
   
   ### Actual results
   Queries are run with the current username in the datasource URL which has replaced the configured default username of the datasource URL, but the password in the URL remains the default one configure on the datasource.
   The attached image shows the error resulting in saving the datasource after having activated the impersonation feature.
   ![401-saving-presto-datasource](https://user-images.githubusercontent.com/19774518/55222555-81117180-520c-11e9-83ed-77f23040cbf8.PNG)
   
   ### Steps to reproduce
   Configure PrestoDB datasource with SSL and username/password configured (like shown in attached image), activate impersonation feature, and save the datasource.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org