You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Clint Popetz (JIRA)" <ji...@apache.org> on 2009/02/09 12:52:59 UTC
[jira] Created: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
------------------------------------------------------------------------------------------
Key: WICKET-2090
URL: https://issues.apache.org/jira/browse/WICKET-2090
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-RC1, 1.3.5
Reporter: Clint Popetz
Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Clint Popetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677733#action_12677733 ]
Clint Popetz commented on WICKET-2090:
--------------------------------------
Could this make it into 1.3.6? Just curious; I can build local snapshots if not. Also, what's the best corresponding hook for writing the data when the response is finished. I'm currently using WebRequestCycleProcessor.respond(); is that appropriate/reliable?
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Attachments: wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675702#action_12675702 ]
Igor Vaynberg commented on WICKET-2090:
---------------------------------------
clint, have you had a chance to try this out?
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Attachments: wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Clint Popetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678203#action_12678203 ]
Clint Popetz commented on WICKET-2090:
--------------------------------------
This worked perfectly on all the tests I have, and in container. Thanks Igor.
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Assignee: Igor Vaynberg
> Attachments: wicket-2090-2.txt, wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2090:
----------------------------------
Attachment: wicket-2090.txt
lets try this simple patch first. seam can provide its own webrequestcycle subclass and attach any metadata in requestcycle.onrequesttargetset(target). there you can check if target is instance of IPageRequestTarget and retrieve the page.
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Attachments: wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Clint Popetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677730#action_12677730 ]
Clint Popetz commented on WICKET-2090:
--------------------------------------
Igor, sorry it took me so long to get back to this. Thanks for the patch. It works for me, both in container and in testing with WicketTester.
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Attachments: wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Clint Popetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678054#action_12678054 ]
Clint Popetz commented on WICKET-2090:
--------------------------------------
Ugh, I spoke to soon. Running our full test suite shows that setRequestTarget isn't always called. For example, if one does formTester.submit(), the trace is:
submit -> RequestCycle.processRequestCycle -> request -> steps() -> step()
which does this on RESOLVE_TARGET:
// Add (inserting at the bottom) in case before or during
// target resolving one or more request targets were pushed
// on the stack before this. If that is the case, they
// should be handled before this
requestTargets.add(0, target);
and never calls setRequestTarget. I'm willing to offer a patch on this, but this code looks rather important and I hesitated to do so without a better grasp of the ways the request cycle is used.
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Attachments: wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2090:
----------------------------------
Attachment: wicket-2090-2.txt
yeah, missed that. here is a better patch. give it a try and let me know.
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Attachments: wicket-2090-2.txt, wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2090.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-RC3
1.3.6
just applied it, you can pull it out of wicket-1.3.x branch.
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Assignee: Igor Vaynberg
> Fix For: 1.3.6, 1.4-RC3
>
> Attachments: wicket-2090-2.txt, wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-2090) Need reliable hook for
storing/restoring data to/from page metadata that is tes compatbile
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-2090:
-------------------------------------
Assignee: Igor Vaynberg
> Need reliable hook for storing/restoring data to/from page metadata that is tes compatbile
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-2090
> URL: https://issues.apache.org/jira/browse/WICKET-2090
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: Clint Popetz
> Assignee: Igor Vaynberg
> Attachments: wicket-2090-2.txt, wicket-2090.txt
>
>
> Requesting a hook to reliable store/restore data to/from page metadata before/after requests that works with WicketTester. Currently I'm using WebRequestCycleProcessor.resolve() and and respond(), but BaseWicketTester.clickLink() doesn't run processRequestCycle before executing the onClick() handler, so this doesnt' work for testing ajax components.
> Original post: http://www.nabble.com/Proper-hook-for-conversational-state-that-also-works-with-tests-td21876375.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.