[GitHub] [sling-org-apache-sling-xss] rombert commented on a diff in pull request #27: SLING-7231 Move to owasp sanitizer library

[GitBox <gi...@apache.org>]

rombert commented on code in PR #27:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/27#discussion_r914831133


##########
.github/workflows/maven-publish.yml:
##########
@@ -0,0 +1,32 @@
+# This workflow will build a package using Maven and then publish it to GitHub packages when a release is created

Review Comment:
   Please remove this file, we use Jenkins for CI.



##########
pom.xml:
##########
@@ -31,7 +31,7 @@
     <!-- P R O J E C T                                                           -->
     <!-- ======================================================================= -->
     <artifactId>org.apache.sling.xss</artifactId>
-    <version>2.2.21-SNAPSHOT</version>
+    <version>2.2.19-SNAPSHOT</version>

Review Comment:
   Please keep the same version, we released 2.2.20 in the meantime.



##########
pom.xml:
##########
@@ -44,10 +44,6 @@
         <url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-xss.git</url>
       <tag>HEAD</tag>
   </scm>
-  
-    <properties>

Review Comment:
   Please add back this property, it is used for reproducible builds.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org