You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/04/02 21:21:13 UTC

[GitHub] [couchdb] bessbd commented on pull request #3490: Fix collation issue for older versions of libicu library

bessbd commented on pull request #3490:
URL: https://github.com/apache/couchdb/pull/3490#issuecomment-812721292


   Thank you for this PR, @nickva !
   When I opened https://github.com/apache/couchdb/pull/3488/commits/4bccaa576a3d56912286e80dafb45e9bf43a137e , my thought was that the sentinel value(s) should never actually be passed to low level code. Ie. it's a nice thing that those sentinels could actually be items that "order well", but they aren't items that are to be compared with others.
   Having said that, I'd be +1 on this change, too.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org