You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2015/03/26 12:59:19 UTC

[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

GitHub user zsxwing opened a pull request:

    https://github.com/apache/spark/pull/5209

    [SPARK-6556][Core] Fix wrong parsing logic of executorTimeoutMs and checkTimeoutIntervalMs in HeartbeatReceiver

    The current reading logic of `executorTimeoutMs` is:
    ```Scala
    private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout", 
        sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) * 1000
    ```
    So if `spark.storage.blockManagerSlaveTimeoutMs` is 10000 and `spark.network.timeout` is not set, executorTimeoutMs will be 10000 * 1000. But the correct value should have been 10000.
    
    `checkTimeoutIntervalMs` has the same issue.
    
    This PR fixes them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zsxwing/spark SPARK-6556

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5209
    
----
commit ccd514700335d40b996dafaa6c6116b4b2d38292
Author: zsxwing <zs...@gmail.com>
Date:   2015-03-26T11:56:03Z

    Fix wrong parsing logic of executorTimeoutMs and checkTimeoutIntervalMs in HeartbeatReceiver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86846252
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29288/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86522111
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29227/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86512694
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29226/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86512683
  
      [Test build #29226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29226/consoleFull) for   PR 5209 at commit [`ccd5147`](https://github.com/apache/spark/commit/ccd514700335d40b996dafaa6c6116b4b2d38292).
     * This patch **passes all tests**.
    
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5209#discussion_r27208000
  
    --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
    @@ -49,12 +49,13 @@ private[spark] class HeartbeatReceiver(sc: SparkContext, scheduler: TaskSchedule
     
       // executor ID -> timestamp of when the last heartbeat from this executor was received
       private val executorLastSeen = new mutable.HashMap[String, Long]
    -  
    -  private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout", 
    -    sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) * 1000
    -  
    -  private val checkTimeoutIntervalMs = sc.conf.getLong("spark.network.timeoutInterval",
    -    sc.conf.getLong("spark.storage.blockManagerTimeoutIntervalMs", 60)) * 1000
    +
    +  private val executorTimeoutMs = sc.conf.getOption("spark.network.timeout").map(_.toLong * 1000).
    --- End diff --
    
    I have not seen them in any docs. However, from the current codes here, I think it's trying to maintain the compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86829270
  
    Fixed the docs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86484779
  
      [Test build #29226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29226/consoleFull) for   PR 5209 at commit [`ccd5147`](https://github.com/apache/spark/commit/ccd514700335d40b996dafaa6c6116b4b2d38292).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by sryza <gi...@git.apache.org>.
Github user sryza commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86807463
  
    Had some nits on the comments.  Otherwise this LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5209#discussion_r27206977
  
    --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
    @@ -49,12 +49,13 @@ private[spark] class HeartbeatReceiver(sc: SparkContext, scheduler: TaskSchedule
     
       // executor ID -> timestamp of when the last heartbeat from this executor was received
       private val executorLastSeen = new mutable.HashMap[String, Long]
    -  
    -  private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout", 
    -    sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) * 1000
    -  
    -  private val checkTimeoutIntervalMs = sc.conf.getLong("spark.network.timeoutInterval",
    -    sc.conf.getLong("spark.storage.blockManagerTimeoutIntervalMs", 60)) * 1000
    +
    +  private val executorTimeoutMs = sc.conf.getOption("spark.network.timeout").map(_.toLong * 1000).
    --- End diff --
    
    You might comment that `timeout` is in seconds and (obviously) `blockManagerSlaveTimeoutMs` is milliseconds. I agree with the change though. These properties you're fixing aren't documented right? the only ref I saw on the mailing list clearly directed people to set values like "60000", which is correctly in ms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86522085
  
      [Test build #29227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29227/consoleFull) for   PR 5209 at commit [`c7d5422`](https://github.com/apache/spark/commit/c7d5422eb0414eb18357a89b155fc4f12db819bb).
     * This patch **passes all tests**.
    
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86830111
  
      [Test build #29288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29288/consoleFull) for   PR 5209 at commit [`6a0a411`](https://github.com/apache/spark/commit/6a0a411578f8e72b42311bf32bda62c75b2956ef).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/5209


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86490567
  
      [Test build #29227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29227/consoleFull) for   PR 5209 at commit [`c7d5422`](https://github.com/apache/spark/commit/c7d5422eb0414eb18357a89b155fc4f12db819bb).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86846222
  
      [Test build #29288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29288/consoleFull) for   PR 5209 at commit [`6a0a411`](https://github.com/apache/spark/commit/6a0a411578f8e72b42311bf32bda62c75b2956ef).
     * This patch **passes all tests**.
    
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by sryza <gi...@git.apache.org>.
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5209#discussion_r27274404
  
    --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
    @@ -49,12 +49,17 @@ private[spark] class HeartbeatReceiver(sc: SparkContext, scheduler: TaskSchedule
     
       // executor ID -> timestamp of when the last heartbeat from this executor was received
       private val executorLastSeen = new mutable.HashMap[String, Long]
    -  
    -  private val executorTimeoutMs = sc.conf.getLong("spark.network.timeout", 
    -    sc.conf.getLong("spark.storage.blockManagerSlaveTimeoutMs", 120)) * 1000
    -  
    -  private val checkTimeoutIntervalMs = sc.conf.getLong("spark.network.timeoutInterval",
    -    sc.conf.getLong("spark.storage.blockManagerTimeoutIntervalMs", 60)) * 1000
    +
    +  // `spark.network.timeout` use `seconds`,
    --- End diff --
    
    Minor nits on the comments:
    * I wouldn't use backticks here because it's not md-formatted.
    * "use" -> "uses"
    * "while" should be on line above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6556][Core] Fix wrong parsing logic of ...

Posted by lianhuiwang <gi...@git.apache.org>.
Github user lianhuiwang commented on the pull request:

    https://github.com/apache/spark/pull/5209#issuecomment-86504920
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org